Fix Scope usage in ServerSentEventEndpointSpec
#3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
requested review from
jdegoes,
vigoo and
987Nabil
as code owners
987Nabil
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is not corret, as it's providing the
Client.defaultto an effect that has the requestScopeas a requirement. This works with ZIO versions up to 2.1.8 since the ZPool implementation leaks its resources (connections) so theZPoolfinalizers are not waiting for the connections to close. When updating ZIO to the latest snapshot this test caused issues (note there might be some underlying bug in ZIO as well, I'll check) but since the test is also badly written I think it's good to fix it here as well