Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZIO to 2.1.11 #3190

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Update ZIO to 2.1.11 #3190

merged 2 commits into from
Nov 4, 2024

Conversation

kyri-petrou
Copy link
Collaborator

For some really weird reason, one of the tests added by @pablf fails when updating ZIO to 2.1.11. The weirdest part is that it fails for all -SNAPSHOT versions after 2.1.9 (even the first one which was just an NPM dependency update).

Based on the comment, I see that the margin was added to account for differences between Scala 2/3. @pablf do you have any idea why do we need to increase this margin now that we're updating the ZIO version even if it doesn't contain any changes that would explain this?

@kyri-petrou
Copy link
Collaborator Author

@987Nabil I think CI is broken. I'm not sure why but I have a feeling that it might be due to this release

@987Nabil
Copy link
Contributor

@kyri-petrou I think I know why. I read from Eugene the sbt guy, that the new Ubuntu images are missing some sbt script and you need a new action he created. Or I guess the cousier setup action can do it as well

@pablf
Copy link
Member

pablf commented Oct 11, 2024

@kyri-petrou I don't see why something like this would happen. It means that something has changed in the length of the actual request that is being sent by zio-http, which is not per se a problem (I'm assuming that changing the ERROR_MARGIN was enough to solve this). The only thing that comes to mind at the moment is something like a transitive dependency impacting encoding of requests.

@kyri-petrou kyri-petrou enabled auto-merge (squash) November 4, 2024 11:10
@kyri-petrou
Copy link
Collaborator Author

@987Nabil could you take a look at the PR when you have 2 mins 🙏

@kyri-petrou kyri-petrou merged commit dc1f3f4 into zio:main Nov 4, 2024
35 checks passed
@kyri-petrou kyri-petrou deleted the update/zio branch November 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants