Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix code to parse Basic Authorization when the password contains ":" #3194

Closed
wants to merge 2 commits into from
Closed

fix code to parse Basic Authorization when the password contains ":" #3194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca937dc
fix code to parse Basic Authorization when the password contains ":"
camarena Oct 23, 2024
eb94ce0
Merge branch 'main' into main
987Nabil Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zio-http/shared/src/main/scala/zio/http/Header.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ object Header {

private def parseBasic(value: String): Either[String, Authorization] = {
try {
val partsOfBasic = new String(Base64.getDecoder.decode(value)).split(":")
val partsOfBasic = new String(Base64.getDecoder.decode(value)).split(":", 2)
if (partsOfBasic.length == 2) {
Right(Basic(partsOfBasic(0), Secret(partsOfBasic(1))))
} else {
Expand Down
Loading