Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickstart for zio sql #52

Merged
merged 7 commits into from
May 20, 2024
Merged

Quickstart for zio sql #52

merged 7 commits into from
May 20, 2024

Conversation

GrigoriiBerezin
Copy link
Contributor

No description provided.

@GrigoriiBerezin GrigoriiBerezin force-pushed the zio_sql_quickstart branch 8 times, most recently from d4365f4 to 634b709 Compare May 6, 2024 14:32
@GrigoriiBerezin
Copy link
Contributor Author

Just noticed that tests don't work for all projects except encode-decode-json. Can we somehow fix it by zio-sbt-ci?

@GrigoriiBerezin GrigoriiBerezin mentioned this pull request May 6, 2024
Open
8 tasks
@GrigoriiBerezin GrigoriiBerezin force-pushed the zio_sql_quickstart branch 3 times, most recently from 0bad6d8 to f9590ae Compare May 10, 2024 14:37
@GrigoriiBerezin
Copy link
Contributor Author

@khajavi finally deal with zio sbt plugin and include all tests from needed modules

@khajavi
Copy link
Member

khajavi commented May 14, 2024

@GrigoriiBerezin
Can you please update the PR and remove any links to external images? It's better to use a random UUID for each image.

@GrigoriiBerezin
Copy link
Contributor Author

Ok, will remove links. And what did you mean by "use a random UUID" for each image? Just insert rows in spec instead of migration script?

@khajavi
Copy link
Member

khajavi commented May 14, 2024 •
edited
Loading

Ok, will remove links. And what did you mean by "use a random UUID" for each image?

I meant it is not necessary to have real image data, you can use UUID for each image instead of external URLs.

Just insert rows in spec instead of migration script?

No problem with the migration script. So let's keep it.

@GrigoriiBerezin
Copy link
Contributor Author

Sorry for long wait, removed real image urls

@khajavi
Copy link
Member

khajavi commented May 20, 2024

@GrigoriiBerezin
Good to merge after fixing the merge conflict.

@GrigoriiBerezin
Copy link
Contributor Author

Will fix links in readme in next quickstarts

@khajavi khajavi merged commit e09c3fc into zio:master May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khajavi khajavi khajavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriiBerezin @khajavi