correct implementation of empty for Sequence

zio · Sep 17, 2024 · 64050bd · 64050bd
1 parent 3abbd4e
commit 64050bd
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 5 deletions.
diff --git a/zio-schema-json/shared/src/test/scala/zio/schema/codec/JsonCodecSpec.scala b/zio-schema-json/shared/src/test/scala/zio/schema/codec/JsonCodecSpec.scala
@@ -1054,15 +1054,15 @@ object JsonCodecSpec extends ZIOSpecDefault {
     suite("Missing collection fields")(
       test("map") {
         assertDecodes(
-          Schema[ListAndMap],
-          ListAndMap(Nil, Map.empty),
+          Schema[ListAndMapAndOption],
+          ListAndMapAndOption(Nil, Map.empty, None),
           charSequenceToByteChunk("""{"list":[]}""")
         )
       },
       test("list") {
         assertDecodes(
-          Schema[ListAndMap],
-          ListAndMap(Nil, Map.empty),
+          Schema[ListAndMapAndOption],
+          ListAndMapAndOption(Nil, Map.empty, None),
           charSequenceToByteChunk("""{"map":{}}""")
         )
       },
@@ -1072,6 +1072,20 @@ object JsonCodecSpec extends ZIOSpecDefault {
           SetWrapper(Set.empty),
           charSequenceToByteChunk("""{}""")
         )
+      },
+      test("vector") {
+        assertDecodes(
+          Schema[VectorWrapper],
+          VectorWrapper(Vector.empty),
+          charSequenceToByteChunk("""{}""")
+        )
+      },
+      test("chunck") {
+        assertDecodes(
+          Schema[ChunckWrapper],
+          ChunckWrapper(Chunk.empty),
+          charSequenceToByteChunk("""{}""")
+        )
       }
     ),
     suite("zio.json.ast.Json decoding")(
@@ -2201,6 +2215,18 @@ object JsonCodecSpec extends ZIOSpecDefault {
     implicit lazy val schema: Schema[SetWrapper] = DeriveSchema.gen[SetWrapper]
   }
 
+  final case class VectorWrapper(sequence: Vector[String])
+
+  object VectorWrapper {
+    implicit lazy val schema: Schema[VectorWrapper] = DeriveSchema.gen[VectorWrapper]
+  }
+
+  final case class ChunckWrapper(chunk: Chunk[String])
+
+  object ChunckWrapper {
+    implicit lazy val schema: Schema[ChunckWrapper] = DeriveSchema.gen[ChunckWrapper]
+  }
+
   final case class KeyWrapper(key: String)
 
   object KeyWrapper {

diff --git a/zio-schema/shared/src/main/scala/zio/schema/Schema.scala b/zio-schema/shared/src/main/scala/zio/schema/Schema.scala
@@ -535,7 +535,7 @@ object Schema extends SchemaPlatformSpecific with SchemaEquality {
 
     override def toString: String = s"Sequence($elementSchema, $identity)"
 
-    override def empty: Col = Seq.empty[Elem].asInstanceOf[Col]
+    override def empty: Col = fromChunk(Chunk.empty[Elem])
   }
 
   final case class Transform[A, B, I](