Ways to ignore empty collections while encoding json #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
force-pushed
the
optional-field-no-json-encoding
branch
from
f4e6de1
to
4b8457e
Compare
vigoo
previously approved these changes
Sep 6, 2023
|
@987Nabil Overall looks good. I am not a fan of the implicit config pattern. Do we have to make that config implicit? |
|
@jdegoes I guess we can have overloaded methods with a config parameter. So we don't break compatibility. |
987Nabil
force-pushed
the
optional-field-no-json-encoding
branch
from
4b8457e
to
67936bb
Compare
vigoo
reviewed
Sep 7, 2023
| @@ -58,7 +65,7 @@ object JsonCodec { | |||
| ) | |||
| } | |||
|
|
|||
| implicit def schemaBasedBinaryCodec[A](implicit schema: Schema[A]): BinaryCodec[A] = | |||
| implicit def schemaBasedBinaryCodec[A](implicit schema: Schema[A], cfg: Config): BinaryCodec[A] = | |||
There was a problem hiding this comment.
Now Config.default is no longer implicit, but here it is an implicit parameter which makes this a bit inconvenient. I suggest to keep an implicit def schemaBasedBinaryCodec with only schema parameter, always using Config.default, so users who want to customize it can use the explicit version.
There was a problem hiding this comment.
Ahh sorry, I missed that part. I did it for the other methods. How you wrote it, was how I planned it.
987Nabil
force-pushed
the
optional-field-no-json-encoding
branch
from
67936bb
to
6135e77
Compare
987Nabil
force-pushed
the
optional-field-no-json-encoding
branch
from
6135e77
to
c97c3dd
Compare
vigoo
previously approved these changes
Sep 7, 2023
987Nabil
force-pushed
the
optional-field-no-json-encoding
branch
from
347fc58
to
e92fac1
Compare
vigoo
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces a config for the JsonCodec, to set behaviour on the codec creation level instead of classes via annotations. We can use this to configure default behaviour in zio-http for example via user config.
Or could make it the default of zio-http to ignore empty collection fields during encoding, without messing with the defaults of zio-schema.