Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding optional integral (Int,Long) at the end of pretty print json. #676

Merged
merged 5 commits into from
May 17, 2024

Conversation

russwyte
Copy link
Contributor

Tests pass

Addresses #675

@russwyte russwyte requested a review from a team as a code owner April 10, 2024 15:07
@russwyte
Copy link
Contributor Author

I did this:
image
But the check still fails... 🤔

@russwyte
Copy link
Contributor Author

Is there something I am missing in this PR? I am happy to add to or modify it or even create a new one.

@987Nabil 987Nabil merged commit ab46e4d into zio:main May 17, 2024
25 checks passed
@987Nabil
Copy link
Contributor

@russwyte Sorry, I was a little busy recently and missed this PR. Let me know, if you need a release soonish for this

@russwyte
Copy link
Contributor Author

Not a big rush - but as soon as practical would be great! Thank you!

@russwyte
Copy link
Contributor Author

@987Nabil Thank you for cutting a release - but it looks like there was an issue publishing it. I don't see it in maven central.

https://mvnrepository.com/artifact/dev.zio/zio-schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants