fix: handle missing collection fields in JSON decoding #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
987Nabil
requested changes
Jun 19, 2024
| } | ||
|
|
||
| // Helper method to create an empty collection based on the schema | ||
| private def createEmptyCollection(schema: Schema[_]): Any = |
There was a problem hiding this comment.
I think this logic belongs to the trait Collection in Schema.scala, so each collection schema has to implement a method that creates an empty collection.
| @@ -104,13 +104,13 @@ object JsonCodec { | |||
| def jsonEncoder[A](cfg: JsonCodec.Config)(schema: Schema[A]): ZJsonEncoder[A] = | |||
| JsonEncoder.schemaEncoder(schema, cfg) | |||
|
|
|||
| def jsonDecoder[A](schema: Schema[A]): ZJsonDecoder[A] = | |||
| def jsonDecoder[A](schema: Schema[A])(implicit config: JsonCodec.Config): ZJsonDecoder[A] = | |||
There was a problem hiding this comment.
Changes are binary incompatible.
Config should not be implicit.
You should not reuse the same config value, since these are two different features. They should be configurable independent of each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #664
/closes #664
/claim #664