Fix JSON decoding of empty objects #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guersam
force-pushed
the
fix-discriminated-caseclass0
branch
from
be4590d
to
116b786
Compare
- discriminated case object - case object with @rejectExtraField
guersam
force-pushed
the
fix-discriminated-caseclass0
branch
from
f9bab51
to
d9a785c
Compare
guersam
commented
Jul 4, 2024
| @@ -991,7 +991,29 @@ object JsonCodec { | |||
| import JsonCodec.JsonDecoder.schemaDecoder | |||
|
|
|||
| private[codec] def caseClass0Decoder[Z](discriminator: Int, schema: Schema.CaseClass0[Z]): ZJsonDecoder[Z] = { (trace: List[JsonError], in: RetractReader) => | |||
| if (discriminator == -1) Codecs.unitDecoder.unsafeDecode(trace, in) | |||
| def skipField(): Unit = { | |||
| val rejectExtraFields = schema.annotations.collectFirst({ case _: rejectExtraFields => () }).isDefined | |||
There was a problem hiding this comment.
Calculating this every time may seem redundant, but skipField() won't run at all in most cases.
There was a problem hiding this comment.
I still think we can make this a val on Schema.Record. Maybe I should do this in my PR
jdegoes
approved these changes
Jul 9, 2024
|
@guersam ask algora ppl in the discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the decoding failure of discriminated case objects.
Example
It also makes case object decoding respect
@rejectExtraFields.However, currently
@rejectExtraFieldscan be applied only to the leaf nodes of ADTs, not the sealed trait/enum itself. To fix this, we need to propagate the parent schema to every caseClassN decoder, but it's out of the scope of this PR. (#700)/claim #711