Non empty collection schemas (#717) #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
force-pushed
the
non-empty-collection
branch
from
5b2d9a7
to
94bf29d
Compare
jdegoes
previously approved these changes
Aug 9, 2024
|
@987Nabil Good to merge when CI is passing. 👍 |
987Nabil
force-pushed
the
non-empty-collection
branch
3 times, most recently
from
be70abe
to
70c1585
Compare
987Nabil
force-pushed
the
non-empty-collection
branch
from
70c1585
to
01a8804
Compare
987Nabil
force-pushed
the
non-empty-collection
branch
3 times, most recently
from
2740a59
to
d2e33a7
Compare
987Nabil
force-pushed
the
non-empty-collection
branch
from
d2e33a7
to
5ceece9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdegoes I went with a new Schema sub type instead of transforming, since it offers a way to introspect in libs. For example, in zio-http query parsing, we can just check that the query params is not there and fail immediately.
Also it is easier to add support for other non empty collections by the user.
fixes #717
/claim #717