Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #737 #738

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Fixes #737 #738

merged 8 commits into from
Sep 10, 2024

Conversation

gregor-rayman
Copy link
Contributor

Fix for the issue #737:

  • separates encoded elements with new lines (so that numbers can be decoded separated)
  • when decoding, looks for boundaries between elements. Needs separators only for numbers. Recognizes automatically the ends of objects, arrays, strings, boolean values and nulls.

@gregor-rayman
Fixes zio#737
9ae0f62 
JsonCodec can encode and decode multiple elements
@gregor-rayman gregor-rayman requested a review from a team as a code owner September 9, 2024 22:21
987Nabil
987Nabil reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@987Nabil 987Nabil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Looks good.

zio-schema-json/shared/src/test/scala/zio/schema/codec/JsonCodecSpec.scala Outdated Show resolved Hide resolved
zio-schema-json/shared/src/test/scala/zio/schema/codec/JsonCodecSpec.scala Outdated Show resolved Hide resolved
zio-schema-json/shared/src/main/scala/zio/schema/codec/JsonCodec.scala Outdated Show resolved Hide resolved
@987Nabil 987Nabil merged commit 6b9753c into zio:main Sep 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@987Nabil 987Nabil 987Nabil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregor-rayman @987Nabil