a new test

zippy84 · Aug 30, 2023 · db4f5d8 · db4f5d8
1 parent 9cb5f7b
commit db4f5d8
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/testing/test_filter.py b/testing/test_filter.py
@@ -863,3 +863,19 @@ def test_bad_shaped():
  bf.Update()
 
  check_result(bf)
+
+@pytest.mark.xfail
+def test_no_contact():
+ cubeA = vtkCubeSource()
+ cubeA.SetCenter(-1, 0, 0)
+
+ cubeB = vtkCubeSource()
+ cubeB.SetCenter(1, 0, 0)
+
+ bf = vtkPolyDataBooleanFilter()
+ bf.SetInputConnection(0, cubeA.GetOutputPort())
+ bf.SetInputConnection(1, cubeB.GetOutputPort())
+ bf.SetOperModeToNone()
+ bf.Update()
+
+ check_result(bf)
diff --git a/vtkPolyDataBooleanFilter.cxx b/vtkPolyDataBooleanFilter.cxx
@@ -160,7 +160,6 @@ int vtkPolyDataBooleanFilter::ProcessRequest(vtkInformation *request, vtkInforma
 #endif
 
  if (contLines->GetNumberOfCells() == 0) {
- vtkErrorMacro("There is no contact.");
  return 1;
  }
 
@@ -2893,6 +2892,8 @@ bool vtkPolyDataBooleanFilter::CombineRegions () {
  regsA->ReverseCell(cellId);
  }
  }
+
+ cellItr->Delete();
  }
 
  if (comb[1] == Loc::INSIDE) {
@@ -2906,6 +2907,8 @@ bool vtkPolyDataBooleanFilter::CombineRegions () {
  regsB->ReverseCell(cellId);
  }
  }
+
+ cellItr->Delete();
  }
 
  }

diff --git a/vtkPolyDataContactFilter.cxx b/vtkPolyDataContactFilter.cxx
@@ -161,6 +161,11 @@ int vtkPolyDataContactFilter::ProcessRequest (vtkInformation *request, vtkInform
  return 1;
  }
 
+ if (contLines->GetNumberOfCells() == 0) {
+ vtkErrorMacro("There is no contact.");
+ return 1;
+ }
+
  if (invalidA) {
  vtkErrorMacro("First input has non-manifold edges.");
  return 1;