Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Schema inheritance issue. #1315

Closed

Conversation

likemusic
Copy link

Fix issue described in #1311 (comment)

it doesn't have #[\OA\Schema] but it have an extended Attribute :

#[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD | \Attribute::TARGET_PROPERTY)]
class ApiExceptionAttribute extends \OpenApi\Attributes\Schema
{}


#[ApiExceptionAttribute]
class Class{}

It doesn't work when I do it like this. Using "type" works only if I use directly \OpenApi\Attributes\Schema

@likemusic likemusic mentioned this pull request Sep 21, 2022
@likemusic likemusic force-pushed the fix-schemas-inheritance-v2 branch from 53f280c to 49bcaee Compare September 23, 2022 17:21
@DerManoMann
Copy link
Collaborator

I know this doesn't break any tests ATM, but I'll need some time thinking about this. I am pretty sure there was a reason for the explicit check... if only I could remember :/

@DerManoMann
Copy link
Collaborator

Superseded by #1403

@DerManoMann DerManoMann closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants