feat: add tls to endpoints #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
evan95s
commented
Mar 27, 2024
•
evan95s
commented
- Support HTTPS endpoint for stage service #5
evan95s
force-pushed
the
feature/tls-support
branch
from
000def8
to
39782c1
Compare
eigmax
reviewed
Mar 29, 2024
eigmax
reviewed
Mar 29, 2024
eigmax
reviewed
Mar 29, 2024
eigmax
reviewed
Mar 30, 2024
common/src/tls.rs
Outdated
| let cert_path = Path::new(&cert_path); | ||
| let key_path = Path::new(&key_path); | ||
| if !ca_cert_path.is_file() || !cert_path.is_file() || !key_path.is_file() { | ||
| return Err(anyhow!( |
eigmax
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
LGTM, @xander42280 plz take a look and help Evan to run the e2e test with Snark prover.
added 2 commits
March 30, 2024 11:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.