add docker-compose & add storage #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeout for test
add docker_compose storage mod & docker-compose
eigmax
reviewed
Apr 4, 2024
prover/src/pipeline.rs
Outdated
| @@ -10,7 +10,7 @@ pub struct Pipeline { | |||
| _mutex: Mutex<usize>, | |||
| } | |||
|
|
|||
| static PIPELINE_MUTEX: Mutex<usize> = Mutex::new(0); | |||
| pub static PIPELINE_MUTEX: Mutex<usize> = Mutex::new(0); | |||
There was a problem hiding this comment.
We should not expose this to public?
prover/src/provers/agg_all_prover.rs
Outdated
| @@ -50,6 +50,10 @@ impl Prover<AggAllContext> for AggAllProver { | |||
| return Ok(()); | |||
| } | |||
|
|
|||
| if proof_num < 1 { | |||
service/src/storage.rs
Outdated
| @@ -0,0 +1,74 @@ | |||
| use mysql_async::prelude::*; | |||
There was a problem hiding this comment.
I think we should use sqlx to support different storage backends, and the sqlx also provides a friendly way to track database changes. https://docs.rs/sqlx/latest/sqlx/macro.migrate.html
service/src/storage.rs
Outdated
| @@ -0,0 +1,74 @@ | |||
| use mysql_async::prelude::*; | |||
|
|
|||
| pub struct Storage { | |||
There was a problem hiding this comment.
This probably conflicts with the Storage for S3 and NFS. We can use Database here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.