Feature/s3 support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
April 3, 2024 08:04
evan95s
force-pushed
the
feature/s3-support
branch
from
c8eac33
to
359d2d8
Compare
eigmax
reviewed
Apr 13, 2024
| } | ||
| } | ||
|
|
||
| async fn s3_read(path: &str) -> anyhow::Result<Vec<u8>> { |
There was a problem hiding this comment.
I think we can make those functions private at the beginning, because we want to expose XXFile, not the those functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3
Add support of s3.
However, something still need to be done.
The feature use some functions which are not implemented in zkMIPS/zkm, so it use a fork source in Cargo.toml, and it should be updated when those functions are merged in main branch of zkMIPS/zkm.