feat: remove redundant check (#166)

* chore: remove redundant check * fix: fmt * fix: typos
zkMIPS · Sep 22, 2024 · 9aed73f · 9aed73f
1 parent 03fd841
commit 9aed73f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -39,7 +39,7 @@ There are two ways to prove the program:
 - Hardware: X86 CPU, 32 cores, 32G memory
 - OS: Ubuntu22
 
-| Cycles Per Segment | RAM |
+| Instructions Per Segment | RAM |
 | ------------------ | --- |
 | 32768 | 13G |
 | 65536 | 19G |

diff --git a/prover/src/cpu/cpu_stark.rs b/prover/src/cpu/cpu_stark.rs
@@ -15,7 +15,7 @@ use crate::constraint_consumer::{ConstraintConsumer, RecursiveConstraintConsumer
 use crate::cpu::columns::{COL_MAP, NUM_CPU_COLUMNS};
 //use crate::cpu::membus::NUM_GP_CHANNELS;
 use crate::cpu::{
- bits, bootstrap_kernel, count, decode, exit_kernel, jumps, membus, memio, misc, shift, syscall,
+ bits, bootstrap_kernel, count, decode, jumps, membus, memio, misc, shift, syscall,
 };
 use crate::cross_table_lookup::{Column, Filter, TableWithColumns};
 use crate::evaluation_frame::{StarkEvaluationFrame, StarkFrame};
@@ -212,7 +212,7 @@ impl<F: RichField + Extendable<D>, const D: usize> Stark<F, D> for CpuStark<F, D
  syscall::eval_packed(local_values, yield_constr);
  bits::eval_packed(local_values, yield_constr);
  misc::eval_packed(local_values, yield_constr);
- exit_kernel::eval_exit_kernel_packed(local_values, next_values, yield_constr);
+ //exit_kernel::eval_exit_kernel_packed(local_values, next_values, yield_constr);
  }
 
  fn eval_ext_circuit(
@@ -244,7 +244,7 @@ impl<F: RichField + Extendable<D>, const D: usize> Stark<F, D> for CpuStark<F, D
  syscall::eval_ext_circuit(builder, local_values, yield_constr);
  bits::eval_ext_circuit(builder, local_values, yield_constr);
  misc::eval_ext_circuit(builder, local_values, yield_constr);
- exit_kernel::eval_exit_kernel_ext_circuit(builder, local_values, next_values, yield_constr);
+ //exit_kernel::eval_exit_kernel_ext_circuit(builder, local_values, next_values, yield_constr);
  }
 
  fn constraint_degree(&self) -> usize {

diff --git a/prover/src/generation/mod.rs b/prover/src/generation/mod.rs
@@ -13,7 +13,6 @@ use crate::all_stark::{AllStark, NUM_TABLES};
 use crate::config::StarkConfig;
 use crate::cpu::bootstrap_kernel::generate_bootstrap_kernel;
 use crate::cpu::columns::CpuColumnsView;
-use crate::cpu::exit_kernel::generate_exit_kernel;
 use crate::cpu::kernel::assembler::Kernel;
 use crate::generation::outputs::{get_outputs, GenerationOutputs};
 use crate::generation::state::GenerationState;
@@ -93,7 +92,7 @@ pub(crate) fn simulate_cpu<F: RichField + Extendable<D>, const D: usize>(
  )
  }
 
- generate_exit_kernel::<F>(state, kernel);
+ //generate_exit_kernel::<F>(state, kernel);
 
  // Padding
  let mut row = CpuColumnsView::<F>::default();

diff --git a/prover/src/prover.rs b/prover/src/prover.rs
@@ -258,7 +258,7 @@ where
  );
  let logic_proof = timed!(
  timing,
- "prove logic STARK",
+ "prove Logic STARK",
  prove_single_table(
  &all_stark.logic_stark,
  config,
@@ -272,7 +272,7 @@ where
  );
  let memory_proof = timed!(
  timing,
- "prove memory STARK",
+ "prove Memory STARK",
  prove_single_table(
  &all_stark.memory_stark,
  config,