Update to new stable #![doc = include_str!]
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Closes #2 (probably) |
|
I'd like to fix #1 before merging this just to have some checks in place, but otherwise this looks good to go! |
Cool! I’m happy to submit a workflow file if you like? |
|
Sure! If not, I'll get to it this weekend. |
|
I might only have time on Monday but will try find a gap 👍 |
|
Hi @hdevalence I added a github actions workflow that should mirror what travis ci was doing, example run here: https://github.com/delta1/subtle-ng/actions/runs/1203724120 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks! We're trying to move to stable rust so I thought I'd contribute this change upstream :)
Removes
feature(external_doc)in favor of#![doc = include_str!]introduced in stable Rust 1.54.Fixed up the tests imports and bumped the version - I understand you may not want these changes but thought I'd offer them for now!
Cheers