Misc improvements across everything #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably controversial but I like visual representations.
This is really dumb.
I'm pretty sure this is actually illegal in some countries. There's probably a better way to do this and if there is, please, god, make this less awful
More questionable design choices.
"rooms_attributes" is actually a byte-per-tile array of actual tiles to use on the overworld for each screen. It is used in GBC mode to determine what tile is actually shown, regardless of the actual physical tile underneath. Used in some places e.g. Mabe Village to give the fancy colored patches of bordered ground (which take up the upper object values, used for tree macros and the like in actual layout objects)
Too good for this world (and too new for even rgbds 0.4.0)
|
Thanks for the quality-of-code improvement, and for fixing the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #214. It is mostly the same, except now it doesn't rely on macro crimes. That should resolve the dependency on rgbds > 0.4.0, but it looks like it's still failing to build and I'm not sure why, so I'm putting this in as a draft until I can figure out exactly why it's complaining.
This should finally close #93, and makes some progress on #201, though only for the pre-made debug save file.