Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entities: document ReturnIfNonInteractive #382

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Conversation

kemenaran
Copy link
Collaborator

For the lack of a better name.

@daid
Copy link
Collaborator

daid commented Jul 5, 2021

Pretty sure this is one of those functions that exists in multiple banks.

@kemenaran kemenaran force-pushed the document-return-entity branch from ead837d to 0217493 Compare July 8, 2021 06:22
@kemenaran kemenaran force-pushed the document-return-entity branch from 0217493 to 3c25a41 Compare July 8, 2021 06:26
@kemenaran
Copy link
Collaborator Author

@daid indeed; I ended up documenting all the variants in entities bank too.

@daid
Copy link
Collaborator

daid commented Jul 8, 2021

I think the function that prevents link from walking into an NPC is also duplicated across multiple banks. As well as talking to NPCs. See: https://github.com/daid/LADXR/blob/master/patches/multiworld.py#L57

@kemenaran
Copy link
Collaborator Author

Yup, there are a handful of them–and labeling the duplicates will make the entities code easier to read.

I created an issue for this: #383

(Nice bit of assembly code in your multiworld script btw ✨)

@kemenaran kemenaran merged commit fb6db2e into main Jul 9, 2021
@kemenaran kemenaran deleted the document-return-entity branch July 9, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants