Merge branch 'dev' into dev-history_first_ticket

.bash_completion

@@ -1,6 +1,6 @@
 # --
 # Copyright (C) 2001-2021 OTRS AG, https://otrs.com/
-# Copyright (C) 2021-2022 Znuny GmbH, https://znuny.org/
+# Copyright (C) 2021 Znuny GmbH, https://znuny.org/
 # --
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU AFFERO General Public License as published by

.fetchmailrc.dist

@@ -1,6 +1,6 @@
 # --
 # Copyright (C) 2001-2021 OTRS AG, https://otrs.com/
-# Copyright (C) 2021-2022 Znuny GmbH, https://znuny.org/
+# Copyright (C) 2021 Znuny GmbH, https://znuny.org/
 # --
 # This software comes with ABSOLUTELY NO WARRANTY. For details, see
 # the enclosed file COPYING for license information (AGPL). If you

.github/workflows/ci.yaml

@@ -46,7 +46,7 @@ jobs:
         run: |
           cd "${GITHUB_WORKSPACE}/znuny"
           git init
-          "${GITHUB_WORKSPACE}/codepolicy/bin/znuny.CodePolicy.pl" --all-files
+          "${GITHUB_WORKSPACE}/codepolicy/bin/znuny.CodePolicy.pl" --all-files --mode ci
 
   CPANAudit:
     name: CPANAudit
@@ -77,7 +77,7 @@ jobs:
       - name: Check out repository code
         uses: actions/checkout@v3
         env:
-          fetch-depth: "1"
+          fetch-depth: "0"
 
       - name: Install dependencies
         run: .github/workflows/ci/dependencies.sh
@@ -87,8 +87,10 @@ jobs:
 
       - name: Check Contributors
         run: |
+          git init
+          git config --global --add safe.directory ${GITHUB_WORKSPACE}
           su -c "bin/otrs.Console.pl Dev::Code::ContributorsListUpdate" - otrs
-          if [[ $(git diff --exit-code AUTHORS.md) ]]; then echo 'The ContributorsList is not updated.' && exit 1; else echo 'The ContributorsList is updated.' && exit 0; fi
+          if [ "$(git diff --exit-code AUTHORS.md)" ]; then echo 'The ContributorsList is not updated.' && exit 1; else echo 'The ContributorsList is updated.' && exit 0; fi
 
   Database-Schema:
     name: Database:Schema
@@ -108,15 +110,15 @@ jobs:
 
       - name: Check Database:Schema
         run: |
-          cd /opt/otrs/
           git init
+          git config --global --add safe.directory ${GITHUB_WORKSPACE}
           SCHEMA_FILE=$(find scripts/database -type f -name '*schema.xml')
           SCHEMA_FILE_NAME=$(find scripts/database -type f -name '*schema.xml' | cut -d/ -f3- | sed 's/\.xml$//')
           echo "Found schema file $SCHEMA_FILE"
           echo "Found schema file name $SCHEMA_FILE_NAME"
           su -c "bin/otrs.Console.pl Dev::Tools::Database::XML2SQL --database-type=all --source-path=${SCHEMA_FILE} --target-directory=scripts/database --target-filename=$SCHEMA_FILE_NAME --split-files" - otrs
           git diff --exit-code scripts/database/*schema*
-          if [[ $(git diff --exit-code scripts/database/*schema*) ]]; then echo 'The database schemas are not updated.' && exit 1; else echo 'All database schemas are updated.' && exit 0; fi
+          if [ "$(git diff --exit-code scripts/database/*schema*)" ]; then echo 'The database schemas are not updated.' && exit 1; else echo 'All database schemas are updated.' && exit 0; fi
 
   Database-InitialInsert:
     name: Database:InitialInsert
@@ -136,15 +138,15 @@ jobs:
 
       - name: Check Database:InitialInsert
         run: |
-          cd /opt/otrs/
           git init
+          git config --global --add safe.directory ${GITHUB_WORKSPACE}
           INITIAL_INSERT_FILE=$(find scripts/database -type f -name '*initial_insert.xml')
           INITIAL_INSERT_FILE_NAME=$(find scripts/database -type f -name '*initial_insert.xml' | cut -d/ -f3- | sed 's/\.xml$//')
           echo "Found initial insert file $INITIAL_INSERT_FILE"
           echo "Found initial insert file name $INITIAL_INSERT_FILE_NAME"
           su -c "bin/otrs.Console.pl Dev::Tools::Database::XML2SQL --database-type=all --source-path=$INITIAL_INSERT_FILE --target-directory=scripts/database --target-filename=$INITIAL_INSERT_FILE_NAME" - otrs
           git diff --exit-code scripts/database/*initial_insert*
-          if [[ $(git diff --exit-code scripts/database/*initial_insert*) ]]; then echo 'The database initial inserts are not updated.' && exit 1; else echo 'All database initial inserts are updated.' && exit 0; fi
+          if [ "$(git diff --exit-code scripts/database/*initial_insert*)" ]; then echo 'The database initial inserts are not updated.' && exit 1; else echo 'All database initial inserts are updated.' && exit 0; fi
 
   Migration:
     name: Migration
@@ -180,7 +182,7 @@ jobs:
         run: |
           MIGRATEFILE=$(find scripts -type f -name 'MigrateToZnuny*.pl' -or -type f -name 'DBUpdate-to-*.pl')
           su -c "$MIGRATEFILE --non-interactive" - otrs
-          if [[ "$?" -ne 0 ]]; then echo "The migration was not successful." && exit 1; else echo "The migration was successful." && exit 0; fi
+          if [ "$?" -ne 0 ]; then echo "The migration was not successful." && exit 1; else echo "The migration was successful." && exit 0; fi
 
   RPMSpec:
     name: RPMSpec
@@ -214,11 +216,11 @@ jobs:
 
       - name: Check RPMSpec
         run: |
-          cd /opt/otrs/
           git init
+          git config --global --add safe.directory ${GITHUB_WORKSPACE}
           su -c "bin/otrs.Console.pl Dev::Tools::RPMSpecGenerate" - otrs
           git diff --exit-code scripts/auto_build/spec/
-          if [[ $(git diff --exit-code scripts/auto_build/spec/) ]]; then echo "The RPMSpec's are not updated." && exit 1; else echo "All RPMSpec's are updated." && exit 0; fi
+          if [ "$(git diff --exit-code scripts/auto_build/spec/)" ]; then echo "The RPMSpec's are not updated." && exit 1; else echo "All RPMSpec's are updated." && exit 0; fi
 
   UnitTest-MySQL:
     name: UnitTest:MySQL

.github/workflows/ci/config-mysql.sh

@@ -17,6 +17,9 @@ echo "Use SCHEMA_FILE: $SCHEMA_FILE"
 echo "Use INITIAL_INSERT_FILE: $INITIAL_INSERT_FILE"
 echo "Use SCHEMA_POST_FILE: $SCHEMA_POST_FILE"
 
+echo "Change character set"
+mysql -h mariadb -u "${MYSQL_USERNAME}" -p"${MYSQL_PASSWORD}" -e "ALTER DATABASE otrs DEFAULT CHARACTER SET utf8;ALTER DATABASE otrs DEFAULT COLLATE utf8_unicode_ci;" || exit 1
+
 echo "Create schema"
 mysql -h mariadb -u "${MYSQL_USERNAME}" -p"${MYSQL_PASSWORD}" otrs < "$SCHEMA_FILE" || exit 1
 

.mailfilter.dist

@@ -1,6 +1,6 @@
 # --
 # Copyright (C) 2001-2021 OTRS AG, https://otrs.com/
-# Copyright (C) 2021-2022 Znuny GmbH, https://znuny.org/
+# Copyright (C) 2021 Znuny GmbH, https://znuny.org/
 # --
 # This software comes with ABSOLUTELY NO WARRANTY. For details, see
 # the enclosed file COPYING for license information (AGPL). If you

.mailmap

@@ -22,11 +22,14 @@ Dusan Vuckovic <dusan.vuckovic@otrs.com> vuckovicd <dusan.vuckovic@muehlbVuckovi
 Elias Probst <elias.probst@otrs.com> <mail@eliasprobst.eu>
 Gerald Young <gerald.young@noynim.com> Gerald Young <help@gwy.org>
 Henrik Vetter <hv@znuny.com> Tronsy <77062636+Tronsy@users.noreply.github.com>
+Lukas Bröring <lukas.broering@sectornord.de> lbroering <lukas.broering@sectornord.de>
+Lukas Bröring <lukas.broering@sectornord.de> Lukas Bröring SectorNord AG <91135132+LuBroering@users.noreply.github.com>
 Jens Bothe <jens.bothe@otrs.com> jensoliver <jojo@jbothe.de>
 Jens Pfeifer <jp@znuny.com> Jens Pfeifer <jens.pfeifer@otrs.com>
 Jens Pfeifer <jp@znuny.com> Jens Pfeifer <jens.pfeifer@znuny.com>
 Jens Pfeifer <jp@znuny.com> Jens Pfeifer <mail@jenspfeifer.de>
 Kamil Furtek <kfurtek@dev.opgksoftware.com> Kamil Furtek <kfurtek@opgksoftware.com>
+Kevin Janssen <77158891+BuTzZ@users.noreply.github.com> root <k.janssen@posteo.de>
 Konrad Gumienny <kgumienny@dev.opgksoftware.com> Konrad <kgumienny@dev.opgksoftware.com>
 Konrad Gumienny <kgumienny@dev.opgksoftware.com> Konrad Gumienny <kgumienny@opgksoftware.com>
 Johannes Hörburger <johannes.hoerburger@otrs.com>
@@ -47,10 +50,13 @@ Milan Rakic <mrakic@s7designcreative.com> Milan Rakic <mrakic@s7designcreatieve.
 Milan Rakic <mrakic@s7designcreative.com> Milan Rakic <mrakic@s7designcreative>
 Milan Rakic <mrakic@s7designcreative.com> Milan Rakid <mrakic@s7designcreative.com>
 Moritz Lenz <mlenz@noris.net> Moritz Lenz <moritz@faui2k3.org>
+Niklas Schmitt <ns@znuny.com> Niklas <ns@znuny.com>
 Nils Leideck <nils.leideck@otrs.com> Nils Leideck <nils.leideck@leidex.net>
 Nils Leideck <nils.leideck@otrs.com> nilei <nils.leideck@leidex.net>
-Paul Folkers <83212096+paulfolkers@users.noreply.github.com> Paul Folkers (Sector Nord AG) <83212096+paulfolkers@users.noreply.github.com>
-Paul Folkers <83212096+paulfolkers@users.noreply.github.com> paulfolkers <83212096+paulfolkers@users.noreply.github.com>
+Paul Folkers <paul.folkers@sectornord.de> Paul Folkers (Sector Nord AG) <83212096+paulfolkers@users.noreply.github.com>
+Paul Folkers <paul.folkers@sectornord.de> paulfolkers <83212096+paulfolkers@users.noreply.github.com>
+Paul Folkers <paul.folkers@sectornord.de> paulfolkers <paul.folkers@sectornord.de>
+Paweł Bogusławski <pawel.boguslawski@ib.pl> Pawel Boguslawski <pawel.boguslawski@ib.pl>
 Renée Bäcker <info@perl-services.de> <github@renee-baecker.de>
 Renée Bäcker <info@perl-services.de> <renee.baecker@otrs.com>
 Renée Bäcker <info@perl-services.de> Renee <reb@perl-services.de>
@@ -71,6 +77,7 @@ Sławomir Niedbała <sniedbala@dev.opgksoftware.com> Slawomir Niedbala <sniedbal
 Sławomir Niedbała <sniedbala@dev.opgksoftware.com> Slawomir <sniedbala@dev.opgksoftware.com>
 Sławomir Niedbała <sniedbala@dev.opgksoftware.com> Slawomir <sniedbala@opgksoftware.com>
 Sławomir Niedbała <sniedbala@dev.opgksoftware.com> Sławomir Niedbała <sniedbala@opgksoftware.com>
+Tim Puettmanns <tim.puettmanns@maxence.de> tipue <tim.puettmanns@maxence.de>
 Thorsten Eckel <te@znuny.com> Thorsten <thorsteneckel@posteo.de>
 Thorsten Eckel <te@znuny.com> Thorsten Eckel <te@zammad.com>
 Thorsten Eckel <te@znuny.com> Thorsten Eckel <thorsten.eckel@otrs.com>
@@ -85,8 +92,8 @@ Zoran Ilibasic <zilibasic@s7designcreative.com> Zoran Ilibasic <zilibasic@s7desi
 tipue <tim.puettmanns@maxence.de> tipue <80031303+tipue-dev@users.noreply.github.com>
 
 # Assign unknown entries to anonymous
-anonymous <unknown@anonymous> Weblate Admin <operations@znuny.com>
-anonymous <unknown@anonymous> Weblate <noreply@weblate.org>
+Znuny Weblate <do-not-reply@znuny.com> Weblate Admin <operations@znuny.com>
+Znuny Weblate <do-not-reply@znuny.com> Weblate <noreply@weblate.org>
 anonymous <unknown@anonymous> atif <>
 anonymous <unknown@anonymous> nicolas <>
 anonymous <unknown@anonymous> otrsintern <otrsintern@gmail.com>

.procmailrc.dist

@@ -1,6 +1,6 @@
 # --
 # Copyright (C) 2001-2021 OTRS AG, https://otrs.com/
-# Copyright (C) 2021-2022 Znuny GmbH, https://znuny.org/
+# Copyright (C) 2021 Znuny GmbH, https://znuny.org/
 # --
 # This software comes with ABSOLUTELY NO WARRANTY. For details, see
 # the enclosed file COPYING for license information (AGPL). If you

AUTHORS.md

@@ -50,7 +50,7 @@ The following persons contributed to Znuny:
 * Konrad Gumienny <kgumienny@dev.opgksoftware.com>
 * LotharZok <111051858+LotharZok@users.noreply.github.com>
 * Luca Maranzano <liuk@linux.it>
-* Lukas Bröring SectorNord AG <91135132+LuBroering@users.noreply.github.com>
+* Lukas Bröring <lukas.broering@sectornord.de>
 * Manuel Hecht <manuel.hecht@otrs.com>
 * Marc Bonsels <marc.bonsels@otrs.com>
 * Marc Nilius <marc.nilius@otrs.com>
@@ -69,6 +69,7 @@ The following persons contributed to Znuny:
 * Never <never.min@gmail.com>
 * NeverMin <never.min@gmail.com>
 * Niels Dimmers <niels@nielsdimmers.nl>
+* Niklas Schmitt <ns@znuny.com>
 * Nils Fiedler <nils.fiedler@otrs.com>
 * Nils Leideck <nils.leideck@otrs.com>
 * Norihiro Tanaka <noritnk@kcn.ne.jp>
@@ -77,7 +78,7 @@ The following persons contributed to Znuny:
 * Olivier Sallou <olivier.sallou@irisa.fr>
 * Patrick Brischler <patrick.brischler@otrs.com>
 * Patrick Rauscher <prauscher@ohai.su>
-* Paul Folkers <83212096+paulfolkers@users.noreply.github.com>
+* Paul Folkers <paul.folkers@sectornord.de>
 * Paul Waring <paul@xk7.net>
 * Paweł Bogusławski <pawel.boguslawski@ib.pl>
 * Peter Krantz <peter@peterkrantz.se>
@@ -102,12 +103,14 @@ The following persons contributed to Znuny:
 * Thomas Raith <thomas.raith@otrs.com>
 * Thomas Wouters <thomas@sijn.org>
 * Thorsten Eckel <te@znuny.com>
+* Tim Puettmanns <tim.puettmanns@maxence.de>
 * Torsten Thau <Torsten.Thau@cape-it.de>
 * Udo Bretz <udo.bretz@otrs.com>
 * Uwe Dieckmann <uwe.dieckmann@otrs.com>
 * Walter Souto <walter.souto@saude.go.gov.br>
 * Wojciech Kuchta <klapi85@gmail.com>
 * Yuri Myasoedov <ymyasoedov@yandex.ru>
+* Znuny Weblate <do-not-reply@znuny.com>
 * Zoran Ilibasic <zilibasic@s7designcreative.com>
 * akmet <akmet@users.noreply.github.com>
 * anonymous <unknown@anonymous>

CHANGES.md

@@ -1,18 +1,53 @@
-# 6.4.4 2022-??-??
+# 6.5.1 2023-??-??
+ - 2023-01-10 Sector Nord AG: Fixed popup description long were cut off in Customer Interface. Thanks to Sector Nord AG (@jsinagowitz). [PR#331](https://github.com/znuny/Znuny/pull/331)
+ - 2023-01-09 Integrated package Znuny4OTRS-UserMaxArticlesPerPage.
+ - 2023-01-06 Fixed 'ACL misbehaviour in processes' - ActivityEntityID is missing in AgentTicketProcess.pm. [#316](https://github.com/znuny/Znuny/issues/316)
+ - 2023-01-05 Fixed JavaScript error in edit-mode in AdminACL.
+ - 2023-01-05 Changed JS alert() function to Core.UI.Dialog.ShowAlert().
+ - 2023-01-04 Show PackageRequired- and ModuleRequired-information while package installation & update.
+ - 2023-01-04 Reworked information of LastViews.
+ - 2023-01-03 Process activity dialog article fields with subject and body can now be pre-filled. The Body also support RichtText. Thanks to Berner Fachhochschule (bfh.ch) for sponsoring this feature.
+ - 2022-12-29 Reenabled TicketID for reporting (Dynamic/TicketList).
+ - 2022-12-19 Added check for maximum filename length to file uploads.
+ - 2022-12-16 Added new function Kernel::System::Web::Request::GetParams() to get request parameters.
+ - 2022-12-13 Fixed SQL injection in TicketSearch.pm (CVE-2022-4427). Thanks for hints to Tim Püttmanns, maxence.
+ - 2022-12-13 Added non-standard time zone mapping for iCal/ICS handling.
+ - 2022-12-12 Fixed bulk un-mention action via mention view link.
+ - 2022-12-07 Added independent ToolBar::TicketProcess. This is only visible when a valid process exists.
+ - 2022-11-30 Replaced dynamic field type WebserviceText with WebserviceDropdown.
+ - 2022-11-25 Moved code of ITSMCore to Znuny Framework that will only be executed if ITSM actually is installed.
+ - 2022-11-24 Fixed handling of empty result for frontend autocompletion of dynamic field type WebserviceMultiselect.
+ - 2022-11-24 SOAP::Lite: Data of elements with attribute 'xsi:type' now will be returned as a hash or array instead of an arbitrary object that Znuny cannot handle.
+ - 2022-09-16 Auto responses now will not be sent if the recipient would be a system address.
+
+# 6.4.5 2022-12-20
+ - 2022-12-13 Fixed SQL injection in TicketSearch.pm (CVE-2022-4427). Thanks for hints to Tim Püttmanns, maxence.
+
+# 6.4.4 2022-11-23
+ - 2022-11-10 Fixed overlapping input list in search dialog.
+ - 2022-11-09 Fixed displayed value for dynamic field type WebserviceText when template placeholder <OTRS_TICKET_DynamicField_*_Value> is being used. [#297](https://github.com/znuny/Znuny/issues/297)
+ - 2022-11-02 Added missing migration for generic interface mapping module Znuny4OTRSAdvanced.
+ - 2022-10-28 Sector Nord AG: Processmanagement AppointmentCreate - removed unnecessary filter on read permission for CalendarName. Thanks to Sector Nord AG (@LuBroering - Lukas Bröring). [PR#302](https://github.com/znuny/Znuny/pull/302)
+ - 2022-10-27 Fixed "Invalid date/time string" errors in otrs.Daemon.pl. Thanks to Paweł Bogusławski (@pboguslawski). [PR#311](https://github.com/znuny/Znuny/pull/311)
  - 2022-10-26 Fixed sorting of SysConfig entity value types.
  - 2022-10-25 Added migration module to add dynamic fields 'TicketCalendarStartTime' and 'TicketCalendarEndTime'.
  - 2022-10-21 Agent error screen now shows navigation bar if possible.
+ - 2022-10-13 Fixed SQL condition in Kernel::System::CustomerUser::DB::CustomerSearch.
+ - 2022-10-12 S/MIME certificates will now be reindexed during Znuny migration.
+ - 2022-10-12 Increased size of column "subject" of table "smime_keys".
  - 2022-10-11 Added input field for OAuth2 token scope to admin dialog.
  - 2022-10-07 Integrate DashboardMyLastChangedTickets. Thanks to Renée Bäcker (@reneeb). [PR#177](https://github.com/znuny/Znuny/pull/177)
- - 2022-10-07 Renamed changed Settings from FrontendRichText::Path to Frontend::RichText::Path. Thanks to Emin Yazi (@eyazi), Efflux. Thanks to Tim Püttmanns (@tipue-dev), maxence. [PR#304](https://github.com/znuny/Znuny/pull/304)
+ - 2022-10-07 Renamed changed settings from FrontendRichText::Path to Frontend::RichText::Path. Thanks to Emin Yazi (@eyazi), Efflux. Thanks to Tim Püttmanns (@tipue-dev), maxence. [PR#304](https://github.com/znuny/Znuny/pull/304)
  - 2022-10-05 Improved usability - AgentTicketBulk - Set DynamicField_NAMEUsed checkbox to true if it is set before or if dynamic field is mandatory.
  - 2022-09-29 Fixed bug - hour 0 is not possible in the default settings for TimeWorkingHours. Thanks to Sector Nord AG (@LuBroering - Lukas Bröring). [PR#296](https://github.com/znuny/Znuny/pull/296)
  - 2022-09-28 Sector Nord AG: Added Sysconfig options to control more settings of CKEditor. Thanks to Sector Nord AG (@jsinagowitz). [PR#285](https://github.com/znuny/Znuny/pull/285)
  - 2022-09-27 Fixed TransitionValidation CheckValueGet() - Added already replaced value 'FieldValue'.
  - 2022-09-27 Added FilterViews for FilterAppointments function.
  - 2022-09-27 Changed way of ticket acl checking for AgentTicketActionCommon from name to login.
+ - 2022-09-26 Added missing HTML filter to AgentTicketZoom/MentionsTable template.
  - 2022-09-26 Fixed Bug in SupportDataCollector plugin for default user.
- - 2022-09-22 Added support for ICS calendar events attachments/string data. Added information section and modal dialog for calendar events to AgentTicketZoom view.
+ - 2022-09-26 Added missing HTML filter to AgentTicketActionCommon template.
+ - 2022-09-22 Prepared support for ICS calendar events attachments/string data. Prepared information section and modal dialog for calendar events to AgentTicketZoom view. Both not activated yet due to issues with WET/WEST timezone.
 
 # 6.4.3 2022-09-21
  - 2022-09-20 Misc. improvements for user mentions.
@@ -242,6 +277,17 @@
  - 2021-06-15 Use ticket title as the default appointment title (#90). Thanks to Renée Bäcker (@reneeb). [#90](https://github.com/znuny/Znuny/pull/90)
  - 2021-06-15 Column list validation before saving agent preferences (#84). Thanks to Paweł Bogusławski (@pboguslawski). [#84](https://github.com/znuny/Znuny/pull/84)
 
+# 6.0.48 2022-12-20
+ - 2022-12-13 Fixed SQL injection in TicketSearch.pm (CVE-2022-4427). Thanks for hints to Tim Püttmanns, maxence.
+
+# 6.0.47 2022-11-23
+ - 2022-11-10 Fixed overlapping input list in search dialog.
+ - 2022-10-27 Fixed "Invalid date/time string" errors in otrs.Daemon.pl. Thanks to Paweł Bogusławski (@pboguslawski). [PR#311](https://github.com/znuny/Znuny/pull/311)
+ - 2022-10-21 Agent error screen now shows navigation bar if possible.
+ - 2022-10-13 Fixed SQL condition in Kernel::System::CustomerUser::DB::CustomerSearch.
+ - 2022-09-29 Fixed bug - hour 0 is not possible in the default settings for TimeWorkingHours. Thanks to Sector Nord AG (@LuBroering - Lukas Bröring). [PR#296](https://github.com/znuny/Znuny/pull/296)
+ - 2022-09-26 Added missing HTML filter to AgentTicketActionCommon template.
+
 # 6.0.46 2022-09-21
  - 2022-09-07 Fixed log flooding via Net::LDAP. Reduction of LDAP_SIZELIMIT_EXCEEDED messages. Thanks to Paweł Bogusławski (@pboguslawski). [PR#178](https://github.com/znuny/Znuny/pull/178)
  - 2022-09-07 Improved nonexistent and invalid service names handling in postmaster filters. Thanks to Paweł Bogusławski (@pboguslawski). [PR#197](https://github.com/znuny/Znuny/pull/197)