Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector Nord AG: Textarea element now expands in both directions. #489

Conversation

ZTrotter
Copy link
Contributor

Proposed change

The <textarea> element currently only expands in one direction, usually horizontally. This causes issue when writing longer text in the field. As it stands <textarea> holds the CSS property flex: 1;, an abbreviation of the three proprieties flex-grow: 1; flex-shrink: 1; flex-basis: 0%;. The issue is being caused by the property flex-basis: 0%;, because it sets the initial width to 0, but leaves the height unaltered by the flex property ( in the case the flex container is set to a row orientation).

The proposed change is to change the value of the flex property from flex: 1; to flex: 1 auto;, which adjusts the initial width and height, which in turn allows the flex container to adjust both values on expansion. This change would set the new values to flex-grow: 1; flex-shrink: 1; flex-basis: auto;.

Type of change

🐞 bug 🐞

Additional information

Many areas were tested ti see if this change creates and unwanted effects.
These areas include:

  • SQL-Box
  • Deactivated Richtext-Editor boxes
  • AdminProcessManagement, AdminProcessManagementActivityDialog and it's popup window
  • Dynamic fields in masks
  • Various other admin masks e.g AdminAutoResponse

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@rkaldung rkaldung added 1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified. labels Aug 24, 2023
@dennykorsukewitz dennykorsukewitz self-assigned this Oct 18, 2023
@dennykorsukewitz dennykorsukewitz self-requested a review October 18, 2023 09:45
@dennykorsukewitz dennykorsukewitz changed the title Sector Nord AG: Textarea element now expands in both directions Sector Nord AG: Textarea element now expands in both directions. Oct 18, 2023
@dennykorsukewitz dennykorsukewitz added this to the rel-7_0_13 milestone Oct 18, 2023
@dennykorsukewitz dennykorsukewitz added the 3 - wait for merge Znuny, it's your turn. label Oct 18, 2023
@NiklasSchmitt NiklasSchmitt merged commit 9e85e0e into znuny:dev Nov 6, 2023
@NiklasSchmitt NiklasSchmitt removed the 3 - wait for merge Znuny, it's your turn. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 2 - Frontend 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

4 participants