Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SectorNordAG: Pressing 'Enter' key inside of <input> triggers wrong event in AgentTicketNote. #554

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

SectorNordAG: Pressing 'Enter' key inside of <input> triggers wrong event in AgentTicketNote. #554

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4b3513
Bugfix: Clicking 'Enter' inside of <input> triggers wrong event.
ZTrotter Sep 25, 2023
fa1d81b
Added preventDefault() to avoid multiple events triggering
ZTrotter Sep 25, 2023
06efcf8
Corrected issue preventing expected behaviour
ZTrotter Jan 19, 2024
29ac118
Update var/httpd/htdocs/js/Core.Form.js
ZTrotter Jan 19, 2024
f80cf2c
Update var/httpd/htdocs/js/Core.Form.js
ZTrotter Jan 19, 2024
d48981f
Bugfix: Forms without clickable a button now submittable via Enter key.
ZTrotter Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion var/httpd/htdocs/js/Core.Form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,16 @@ Core.Form = (function (TargetNS) {
$("form input, select, textarea").off('change', FormModified);
}

/**
* This makes all forms submittable by using Enter inside inputs.
*/
$('body').on('keydown', 'input', function (Event) {
if (Event.keyCode == 13 && $(this).closest('form').find(':submit').length > 0) {
Event.preventDefault();
$(this.form).find(':submit').last().click();
}
});

/**
* This makes all forms submittable by using Ctrl+Enter inside textareas.
* On macOS you can use Command+Enter instead.
Expand All @@ -302,7 +312,8 @@ Core.Form = (function (TargetNS) {
if ((Event.ctrlKey || Event.metaKey) && Event.keyCode == 13) {
// We need to click() instead of submit(), since click() has
// a few useful event handlers tied to it, like validation.
$(this.form).find(':submit').first().click();
Event.preventDefault();
$(this.form).find(':submit').last().click();
}
});

Expand Down