Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require ruby2_keywords when testing in ruby < 2.7 #244

Merged
merged 1 commit into from
Sep 29, 2024
Merged

require ruby2_keywords when testing in ruby < 2.7 #244

merged 1 commit into from
Sep 29, 2024

Conversation

pcai
Copy link
Contributor

@pcai pcai commented Sep 29, 2024 •
edited
Loading

fixes #240

test_helper.rb specifically requires rails/test_help which in activesupport 6.x uses drb 2.0.6 which uses ruby2_keywords before anything else explicitly requires it

when running ruby < 2.7 this blows up

@pcai pcai changed the title require ruby2_keywords in ruby < 2.7 require ruby2_keywords when testing in ruby < 2.7 Sep 29, 2024
@pcai pcai merged commit fca88a3 into main Sep 29, 2024
69 checks passed
@pcai pcai deleted the ruby2_keywords branch September 29, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate rails 6.x breakage with ruby 2.5, 2.6
1 participant
@pcai