-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update queries for workflow counts #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount to Materialized Only View
db/migrate/20240926225916_create_hourly_workflow_classification_count.rb
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how the FE calls out /classifications?workflow_id endpoint when querying from project's stats (i.e. all at once), which is hammering the API and Timescale db. 🔨
This ^ (and our non-usage of compression or data retention policies) plus our usage of Real Time Aggregates on the continuous aggregate we query workflow data from, causes querying to be not performant. (As evident when turning off Real Time Aggregation, we see faster query times and lower cpu utilization).
Because we are limited in resources and we still want Real Time Aggregation to be possible, we do the following for querying workflow classification counts ONLY:
Some details:
day, week, month, or year
, we need to ensure we append the current date counts as a new entry with the proper start date of the appended period. Otherwise, its a simple add current date counts to the newest bucket, if there is a newest bucket entry. More detail in the next bulletinclude_today_to_scoped
in count_classifications, we take care of the following cases:- for a given workflow, there are no classifications past or current => returns the empty past classifications counts
- for a given workflow, there are past classifications but no current classifications => returns past classifications counts
- for a given workflow, there are no past classifications but there are current classifications (i.e. a new workflow) => returns todays_classifications with proper period bucket start date
- for a given workflow, there are past classifications and current classifications
A) if part of the most recent past classifications bucket, then add
B) if not, then append with proper period bucket start date