Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore post-install scripts #6393

Closed

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Oct 17, 2024

The GitHub CI workflows and the Docker builds already run yarn install with the --ignore-scripts flag. This PR makes the same change to the bootstrap scripts for local development.

I've also tidied up bin/bootstrap.sh so that it only runs the install once, then builds the various packages in order.

Please request review from @zooniverse/frontend team or an individual member of that team.

Linked Issue and/or Talk Post

How to Review

yarn bootstrap should build the various packages as usual. Tests should still run, and the Next.js apps should still run.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

@coveralls
Copy link

coveralls commented Oct 17, 2024

Coverage Status

coverage: 77.762% (+0.03%) from 77.729%
when pulling fd9e4d0 on eatyourgreens:ignore-install-scripts
into f54edb8 on zooniverse:master.

The GitHub CI workflows and Docker builds already run `yarn install` with the `--ignore-scripts` flag. This PR makes the same change to the bootstrap scripts for local development.

I've also tidied up `bin/bootstrap.sh` so that it only runs the install once, then builds the various packages in order.
@goplayoutside3
Copy link
Contributor

The changes here are superseded by #6446. Okay to close?

@eatyourgreens
Copy link
Contributor Author

Sounds good. #6446 should close #6391 too, since it globally disables post-install scripts.

@eatyourgreens eatyourgreens deleted the ignore-install-scripts branch November 7, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn bootstrap errors on MacOS while building the canvas dependency
3 participants