-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor homepage recent projects to use ERAS #6397
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 32 additions & 66 deletions
98
...ges/lib-user/src/components/UserHome/components/RecentProjects/RecentProjectsContainer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import { SpacedText } from '@zooniverse/react-components' | ||
import { Anchor } from 'grommet' | ||
import { shape, string } from 'prop-types' | ||
import { object, oneOfType, shape, string } from 'prop-types' | ||
import styled from 'styled-components' | ||
|
||
const StyledAnchor = styled(Anchor)` | ||
font-family: 'Karla', Arial, sans-serif; | ||
font-family: 'Karla', Arial, sans-serif; | ||
font-size: 1rem; | ||
line-height: normal; | ||
background: none; | ||
|
@@ -45,7 +45,7 @@ function ContentLink({ | |
|
||
ContentLink.propTypes = { | ||
link: shape({ | ||
as: string, | ||
as: oneOfType([object, string]), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes a |
||
href: string, | ||
text: string | ||
}) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's an issue, but noting if I have 20 projects per line 19, but then private/deleted projects are filtered out here, then there might be less than 20 or an inconsistent number of projects for some users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think this is fine for the homepage, but we'll need to discuss handling private and/or deleted projects when creating an All Projects page with 20-per-page pagination.