-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: docker instructions and fixes #6465
Conversation
- replace the outdated `docker-compose` command with `docker compose` in the READMEs. - fix `AS` in Dockerfile. - update the Docker instructions in the READMEs. - make sure that environment variables are set for local development in the `docker-compose.yml` files.
This PR gets the project Docker builds working on a MacBook, but if no one uses Docker to run The top-level |
52284ba
to
3ab9772
Compare
If you're new to Docker, here's a description of images vs. containers: |
a20915f
to
d6594c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Thank you for your help in getting Docker sorted out!
I'm able to use docker compose at the root and app-project. I'll push some updates to the docker-compose.yml
for app-root too (and its Readme).
I'm also going to run a test deploy to the fe-project-branch just to be safe before approval/merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success 👍 Build run
🎉 |
docker-compose
command withdocker compose
in the READMEs.AS
in Dockerfile.docker-compose.yml
files.Please request review from
@zooniverse/frontend
team or an individual member of that team.Linked Issue and/or Talk Post
How to Review
To build and run the monorepo packages from the root directory:
That runs production builds of the project app and root app in a container:
Shut down the running services and test the project docker compose config:
docker compose down cd packages/app-project docker compose up -d
That runs
yarn dev
for the project app and starts a development storybook. In theory, local changes to the project app should trigger hot module reloading in the running container:Shut down the project services:
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expected