Replace file reads and writes utilizing Path (fixes #8) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataflake
approved these changes
Nov 29, 2023
d-maurer
approved these changes
Nov 29, 2023
Thanks, reviewers! I'll add the missing entry pronto. |
|
@jan-jockusch In case you're not aware, the PR author - you - does the final merge when the prerequisites like passing tests and reviewer approval are met. |
Thanks for the reminder! Yes, I thought that's the rule and was about to, but I wanted to make sure I don't trespass and was therefore looking for docs to confirm I have the green light. It's been a while since I last contributed… |
|
Great, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rather stupidly followed the suggestions made by @leorochael in this PR, just to help out a bit.