Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip titles of html tags + update regex #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

strip titles of html tags + update regex #160

wants to merge 1 commit into from

Conversation

abaevbog
Copy link
Contributor

Strip all html tags from title in getSortTitle function
Update the regex in getSortTitle to not skip double brackets

Fixes: #159

@abaevbog
strip titles of html tags + update regex
4833c9a 
Strip all html tags from title in getSortTitle function
Update the regex in getSortTitle to not skip double brackets

Fixes: zotero#159
@abaevbog abaevbog requested a review from dstillman July 13, 2023 01:20
@abaevbog
Copy link
Contributor Author

I noticed that existing regex does not strip all the special characters listed in the expression. For example "[[[Hello World]]]" becomes "[[Hello World". So I also updated the regex to '/[\[({\\-"\'“‘\])}\-"\'”’]/u' which does not do that.

@abaevbog abaevbog marked this pull request as ready for review July 13, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstillman dstillman Awaiting requested review from dstillman

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strip HTML tags when generating sort title
1 participant
@abaevbog