Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: UI polishing #2985

Merged
merged 51 commits into from
Jul 31, 2023
Merged

chore: UI polishing #2985

merged 51 commits into from
Jul 31, 2023

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Jul 14, 2023 •
edited
Loading

Description

Polish css based on UX feedbacks and improve the properties handling for the style customisation.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@taban03
css polishing
618e6a3 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix warnings
d55fd47 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix test
f94115b 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix some style
7d43215 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
improve handling in case of header set to white
a77522f 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix buttons color
6b9f8f1 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
taban03 and others added 11 commits July 14, 2023 17:53
@taban03
Merge branch 'v2.x.x' into reboot/ui_polishing
7aad1fc
@taban03
small fix for better responsiveness
eb98ef9 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix + test
3a52bf7 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix complexity
f5e101d 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fixing
3c73ee8 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
reduce complexity
23bbb48 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
hide compare button in case of no doc
01347a6 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix wizard bar and add unit tests
be034a4 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix login form
850b282 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix spinner glitch on login
b85fd3d 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
refactor tabs and fix css
e1ee4eb 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
taban03 and others added 8 commits July 20, 2023 17:20
@taban03
get version for compare
4fc7f9f 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix compare versions
427e9c2 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
add tests
65799b1 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
add test
8920533 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
Merge branch 'v2.x.x' into reboot/ui_polishing
449ae1d
@taban03
increase coverage
39a99ca 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix small bug
da7f2d3 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix
e287f09 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix anchors
5e6bdf4 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix media icons and search bar
a7794ee 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
add test
094cb6e 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
small changes
e0bc65e 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix code smell
cc62067 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
increase coverage
a1bcf62 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
add check and hide right menu in case only swagger present
ce45ae8 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
adjust internal doc img size
3e6e0cd 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix tests
3dadb22 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix tests
4505dda 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
pj892031
pj892031 reviewed Jul 25, 2023
View reviewed changes
api-catalog-ui/frontend/src/components/Login/Login.jsx Outdated Show resolved Hide resolved
api-catalog-ui/frontend/src/components/ServiceTab/ServiceTab.jsx Outdated Show resolved Hide resolved
api-catalog-ui/frontend/src/components/ServiceTab/ServiceTab.jsx Outdated Show resolved Hide resolved
api-catalog-ui/frontend/src/components/ServiceTab/ServiceTab.jsx Show resolved Hide resolved
api-catalog-ui/frontend/src/components/ServiceVersionDiff/ServiceVersionDiff.jsx Outdated Show resolved Hide resolved
api-catalog-ui/frontend/src/components/ServicesNavigationBar/ServicesNavigationBar.jsx Show resolved Hide resolved
api-catalog-ui/frontend/src/utils/utilFunctions.js Outdated Show resolved Hide resolved
api-catalog-ui/frontend/src/utils/utilFunctions.js Show resolved Hide resolved
taban03 and others added 12 commits July 26, 2023 14:40
@taban03
address PR comments
83c636a 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
address comments
347782b 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
Merge branch 'v2.x.x' into reboot/ui_polishing
8d65d6f
@taban03
small fix
a995200 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix operation swagger width
1fe8595 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
address comments
fce95db 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix search bar css
5bc276c 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
fix bug of no swagger being displayed when navigating to the detailpage
2059385 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
Merge branch 'v2.x.x' into reboot/ui_polishing
bfbbdb9
@taban03
fix tests
75afa0e 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
add test and adjust css
3b8ce71 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
add unit tests
a157fe7 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03
small fix
57501f2 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.6% 86.6% Coverage
0.0% 0.0% Duplication

@taban03 taban03 merged commit 995d837 into v2.x.x Jul 31, 2023
33 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/ui_polishing branch July 31, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pj892031 pj892031 pj892031 approved these changes

@pablocarle pablocarle Awaiting requested review from pablocarle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taban03 @pj892031