Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: z/OSMF logging improvements #2998

Merged
merged 23 commits into from
Jul 26, 2023
Merged

fix: z/OSMF logging improvements #2998

merged 23 commits into from
Jul 26, 2023

Conversation

pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Jul 21, 2023 •
edited by taban03
Loading

Description

  • Improvements in z/OSMF logging in debug and error handling.

Resolve #2972

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

weinfurt and others added 13 commits July 14, 2023 16:19
@weinfurt
Improve log events for zosmf detection and verification as JWT producer.
d385907 
Signed-off-by: Petr Weinfurt <petr.weinfurt@broadcom.com>
wip minor changes
8524579 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
wip - logs on wrong request to zosmf
0762338 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
wip
959b7f5 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
wip - exception management, pending tests
8f3c1a8 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
remove comments
d9238bb 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
update message after test
7441a7d 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
@Shobhajayanna
Logging a new WARNING message when z/OSMF is not available and change…
669dce6 
…d Events collection to HashSet to retain only unique events.

Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
Added a new WARNING message with code ZWEAG181 when z/OSMF is not ava…
abba8b6 
…ilable

Signed-off-by: sj895092 <shobhackm9@gmail.com>
handle change password error return, pending tests
7ea7f5e 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Merge branch 'reboot/ImproveLoggingZosmf' of https://github.com/zowe/…
95d2d88 
…api-layer into reboot/ImproveLoggingZosmf
cleanup
7493cde 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
change password tests
8537588 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Jul 21, 2023
Pablo Hernán Carle added 3 commits July 21, 2023 15:11
remove log
dc1284b 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
rollback changes
4fb5c96 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
remove test
733e0eb 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
janan07
janan07 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by tech info

Pablo Hernán Carle and others added 5 commits July 24, 2023 10:11
add logs tests
808eddd 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
@pablocarle
Merge branch 'v2.x.x' into reboot/ImproveLoggingZosmf
8ecdc5a
fix checkstyle
0bfae68 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
fix smells
f0f584b 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
add tests for change password cases
205c33f 
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
@pablocarle pablocarle marked this pull request as ready for review July 24, 2023 13:53
@weinfurt
Remove unnecessary private function.
edca2f2 
Signed-off-by: Petr Weinfurt <petr.weinfurt@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.1% 87.1% Coverage
0.0% 0.0% Duplication

weinfurt
weinfurt approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@weinfurt weinfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pablocarle pablocarle merged commit eb7b02e into v2.x.x Jul 26, 2023
33 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/ImproveLoggingZosmf branch July 26, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shobhajayanna Shobhajayanna Shobhajayanna left review comments

@weinfurt weinfurt weinfurt approved these changes

@janan07 janan07 janan07 approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve logging about connectivity to z/OSMF
4 participants
@pablocarle @weinfurt @Shobhajayanna @janan07