Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stacktrace from Catalog log when service is down #3019

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Remove stacktrace from Catalog log when service is down #3019

merged 7 commits into from
Aug 16, 2023

Conversation

JirkaAichler
Copy link
Contributor

Description

Fixes #3008

@JirkaAichler @pablocarle
Update api-catalog-services/src/main/resources/apicatalog-log-message…
2ea69fc 
…s.yml

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: JirkaAichler <39735421+JirkaAichler@users.noreply.github.com>
@JirkaAichler @pablocarle
Update api-catalog-services/src/main/java/org/zowe/apiml/apicatalog/i…
4ba016d 
…nstance/InstanceRetrievalService.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: JirkaAichler <39735421+JirkaAichler@users.noreply.github.com>
janan07
janan07 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API Catalog log message looks good.

pablocarle
pablocarle approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pablocarle pablocarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think it would be better to have tests that verifies what goes and does not go into the logger, I added a couple like these in the ZosmfServiceTest, if there's a test that currently covers this scenario, perhaps you can add an assertion there.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.4% 85.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@JirkaAichler JirkaAichler merged commit b1df6f0 into v2.x.x Aug 16, 2023
33 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-catalog-messages branch August 16, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janan07 janan07 janan07 approved these changes

@pablocarle pablocarle pablocarle approved these changes

@pj892031 pj892031 Awaiting requested review from pj892031

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stacktrace in the Catalog log when service has no API version
3 participants
@JirkaAichler @pablocarle @janan07