chore: Improve conformance validation #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…Testing' into reboot/GH647/improvedConformanceTesting
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…ents on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…Testing' into reboot/GH647/improvedConformanceTesting
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…ents on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
matejpopda
changed the title
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…Testing' into reboot/GH647/improvedConformanceTesting
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
… are the reason why the build fails Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
… are the reason why the build fails Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
… are the reason why the build fails Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…ce:test shouldn't fail anymore Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…ce:test shouldn't fail anymore Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
…Testing' into reboot/GH647/improvedConformanceTesting
…ailing Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
reboot/GH647/improvedConformanceTesting
branch
achmelo
pushed a commit
that referenced
this pull request
Aug 15, 2023
* feat(gateway): Improvement of existing conformance testing Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * refactor(gateway): Added missing comments Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Removed a print statement. Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Better response from the conformance endpoint Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Better response from the conformance endpoint Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * refactor(gateway): Got rid of duplicate discovery client calls Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * docs(gateway): Changed text in gateway-log-messages.yml based on comments on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Addressed the rest of comments on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Addressed the new comments on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Fixed a method not following a naming convention Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Fixed reason why build was failing Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Addressed Pablo's comments on PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Updated an integration test for conformance Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Updated integration tests Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Improvement of existing conformance testing Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * refactor(gateway): Added missing comments Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Removed a print statement. Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Better response from the conformance endpoint Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * refactor(gateway): Got rid of duplicate discovery client calls Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * docs(gateway): Changed text in gateway-log-messages.yml based on comments on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Addressed the rest of comments on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * feat(gateway): Addressed the new comments on the PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Fixed a method not following a naming convention Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Fixed reason why build was failing Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Addressed Pablo's comments on PR Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Updated an integration test for conformance Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Updated integration tests Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Fixed code smells Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Fixed 1 bug from sonar Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Disabled caching on a github action as a test Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Enabled cache again + removed some tests to see if they are the reason why the build fails Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Enabled cache again + removed some tests to see if they are the reason why the build fails Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Enabled cache again + removed some tests to see if they are the reason why the build fails Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Disabled cache again, changed unit tests :gateway-service:test shouldn't fail anymore Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Disabled cache again, changed unit tests :gateway-service:test shouldn't fail anymore Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Modified unit tests Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Modified unit tests Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Modified unit tests Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Fixed unit tests Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Enabled build cache Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Disabled build cache Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Enabled build cache + should create an artifact after failing Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> * fix(gateway): Disabled the creation of artifact from previous commit Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> --------- Signed-off-by: matejpopda <20053580+matejpopda@users.noreply.github.com> Co-authored-by: ShobhaJayanna <36433611+Shobhajayanna@users.noreply.github.com> Co-authored-by: Andrea Tabone <39694626+taban03@users.noreply.github.com> Signed-off-by: achmelo <a.chmelo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworked previous work on conformance verification by apiml
Linked to issue 647
Type of change