-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spring cloud gateway routing #3031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
achmelo
changed the title
(feat) Spring cloud gateway routing
feat: Spring cloud gateway routing
Aug 15, 2023
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
…epend on the bug Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
achmelo
reviewed
Aug 22, 2023
...d-gateway-service/src/main/java/org/zowe/apiml/cloudgatewayservice/service/RouteLocator.java
Outdated
Show resolved
Hide resolved
gateway-service/src/main/java/org/zowe/apiml/gateway/config/GatewayConfig.java
Show resolved
Hide resolved
...teway-service/src/test/java/org/zowe/apiml/cloudgatewayservice/service/RouteLocatorTest.java
Outdated
Show resolved
Hide resolved
...teway-service/src/test/java/org/zowe/apiml/cloudgatewayservice/service/RouteLocatorTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/zowe/apiml/cloudgatewayservice/service/scheme/HttpBasicPassticketTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
achmelo
approved these changes
Aug 22, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs 97.2% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements routing in SCGW. The original implementation contained two ways how to route and it was required to set up this type of routing by APIML_SERVICE_GATEWAY_PROXY_ENABLED.
The new implementation support both and they are as default enabled.
The preferred routing is by header (if the header is set, this type of routing is used). Differences against the original routing by header:
The second way is routing by basePath. There is just one change - it allows to use APIML ID.
New APIML metadata:
apiml.service.externalUrl
apiml.service.apimlId
It also contains:
removeFirstAndLastOccurrence
Linked to #2884
Part of the #2651
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline