Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WebSocket non-blocking session opening #3695

Merged
merged 42 commits into from
Aug 28, 2024
Merged

Conversation

pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Aug 22, 2024

Description

This PR refactors the code in the WebSocket client / server to be non-blocking and callback-based.
Retries are set in place now instead of holding on the thread for a determined amount of time.

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Pablo Hernán Carle and others added 13 commits August 22, 2024 16:50
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Pablo Hernán Carle and others added 10 commits August 26, 2024 10:58
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Pablo Hernán Carle added 4 commits August 27, 2024 10:53
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
@pablocarle pablocarle marked this pull request as ready for review August 27, 2024 11:40
Pablo Hernán Carle added 2 commits August 27, 2024 17:44
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Pablo Hernán Carle added 11 commits August 27, 2024 22:54
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
wip
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Copy link

sonarcloud bot commented Aug 28, 2024

@pablocarle pablocarle merged commit b6f2461 into v2.x.x Aug 28, 2024
31 checks passed
@pablocarle pablocarle deleted the reboot/fix/ws-concurrent branch August 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants