Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Basic HTTP responses in the SCGW #3697

Merged
merged 22 commits into from
Sep 2, 2024
Merged

chore: Basic HTTP responses in the SCGW #3697

merged 22 commits into from
Sep 2, 2024

Conversation

pj892031
Copy link
Contributor

Description

This PR establishes basic messages in JSON format and the classes to easy extension.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@pj892031
basic response code support
48644c2 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
pj892031 and others added 7 commits August 27, 2024 10:44
@pj892031
tests
e83a996 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pj892031
Merge branch 'v3.x.x' into reboot/unused-message-from-v2
402085a
@achmelo
remove unused code
12f554b 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
Merge branch 'v3.x.x' into reboot/unused-message-from-v2
2a04082 
Signed-off-by: achmelo <37397715+achmelo@users.noreply.github.com>
@achmelo
remove lock files
aa7237a 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
throw exception when forbidden character, resolve conflicts
30ef21f 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
retry start of the mock service for acceptance test
48d592d 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo achmelo marked this pull request as ready for review August 29, 2024 11:52
@achmelo
give security analysis permission to write
86bc2b6 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Aug 29, 2024
achmelo and others added 9 commits August 29, 2024 15:37
@achmelo
handle time out
b2a0da2 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
change management port number for test
73fa6e8 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
remove unused code, add more tests
cd7d7a6 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
enable test and expect correct message
b886e66 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
disable management endpoints when not needed
9feec2e 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
enable remaining tests
6d55b93 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
do not validate response message
8815e3b 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
expect not found
7a7fb16 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
Merge branch 'v3.x.x' into reboot/unused-message-from-v2
feeb08a
@achmelo
code review
5625ba7 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
Merge remote-tracking branch 'origin/reboot/unused-message-from-v2' i…
58a687e 
…nto reboot/unused-message-from-v2
@achmelo
code review #2
753ce11 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
pablocarle
pablocarle approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@pablocarle pablocarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you address the issues found in sonar?

@achmelo
fix sonar issues
7a63d7b 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@achmelo achmelo merged commit ddb354a into v3.x.x Sep 2, 2024
31 checks passed
@achmelo achmelo deleted the reboot/unused-message-from-v2 branch September 2, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achmelo achmelo achmelo left review comments

@pablocarle pablocarle pablocarle approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review size/XL
Projects
API Mediation Layer Backlog Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pj892031 @pablocarle @achmelo