Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stacktrace on unreachable swagger and remove handling for depreca… #3699

Merged
merged 7 commits into from
Aug 29, 2024
Merged

fix: stacktrace on unreachable swagger and remove handling for depreca… #3699

merged 7 commits into from
Aug 29, 2024

Conversation

richard-salac
Copy link
Contributor

@richard-salac richard-salac commented Aug 27, 2024 •
edited
Loading

Description

  • replace stacktrace with standardized error message
  • fix resource leak and replace deprecated method
  • tweak reflection in apiml logger

Linked to #3005

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@richard-salac richard-salac self-assigned this Aug 27, 2024
@richard-salac richard-salac changed the title Fix stacktrace on unreachable swagger and remove handling for depreca… fix: stacktrace on unreachable swagger and remove handling for depreca… Aug 27, 2024
@richard-salac richard-salac force-pushed the reboot/GH3005/remove_stacktrace_invalid_swaggerurl branch from 9c45dc9 to b7715be Compare August 27, 2024 12:50
@richard-salac
Fix stacktrace on unreachable swagger
878b0a5 
Remove handling for deprecated z/os
Update deprecated http client execution
Improve ApimlLogger injection

Signed-off-by: Richard Salac <richard.salac@broadcom.com>
@richard-salac richard-salac force-pushed the reboot/GH3005/remove_stacktrace_invalid_swaggerurl branch from b7715be to 878b0a5 Compare August 27, 2024 12:52
pablocarle
pablocarle reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@pablocarle pablocarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked already the uncovered code in Sonar?

@richard-salac
apimlLogger test
13cd0a4 
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
richard-salac and others added 3 commits August 29, 2024 12:35
@richard-salac @pablocarle
Update api-catalog-services/src/test/java/org/zowe/apiml/apicatalog/s…
22be4e9 
…ervices/status/LocalApiDocServiceTest.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: Richard Salač <richard.salac@broadcom.com>
@richard-salac
Merge branch 'v3.x.x' into reboot/GH3005/remove_stacktrace_invalid_sw…
7a689d5 
…aggerurl
@richard-salac
cr fixup
73349f9 
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
pablocarle
pablocarle approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@pablocarle pablocarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments. LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@richard-salac richard-salac merged commit 3606dd6 into v3.x.x Aug 29, 2024
31 checks passed
@richard-salac richard-salac deleted the reboot/GH3005/remove_stacktrace_invalid_swaggerurl branch August 29, 2024 12:54
@richard-salac richard-salac mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocarle pablocarle pablocarle approved these changes

Assignees

@richard-salac richard-salac

Labels
size/L
Projects
API Mediation Layer Backlog Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-salac @pablocarle