Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle exceptions that could arise in the passticket authentication schema #3871

Merged
merged 38 commits into from
Nov 6, 2024
Merged

fix: handle exceptions that could arise in the passticket authentication schema #3871

merged 38 commits into from
Nov 6, 2024

Conversation

pj892031
Copy link
Contributor

@pj892031 pj892031 commented Oct 25, 2024 •
edited by achmelo
Loading

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to #3869
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@pj892031
draft of fixes (except evaluation of client certificate in the ZAAS)
2c5b153 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Oct 25, 2024
@achmelo
Merge remote-tracking branch 'origin/v3.x.x' into reboot/fix-zaas-res…
0c1ffe2 
…ponses
@achmelo
handle exceptions in zaas and unexpected status codes in gateway
7d56ab9 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
align passticket tests with updated status codes, remove invalid test
dfcf766 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
handle safid exceptions in the same way as passticket
abf06aa 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
when content type is omitted
1bedafd 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
remove nested structure
a1a2c03 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
remove error controller
92baceb 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
return not_found handler
71a694c 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
test endpoint not_found
d5a1e89 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
add unit tests
89d5fe7 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
test internal error and not found exception
cdcbb7c 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo achmelo marked this pull request as ready for review November 1, 2024 13:02
@achmelo achmelo changed the title fix: Issues about aplying authentication scheme in GW v3 fix: handle exceptions that could arise in the passticket authentication schema Nov 1, 2024
pablocarle
pablocarle reviewed Nov 1, 2024
View reviewed changes
...es/src/main/java/org/zowe/apiml/apicatalog/controllers/handlers/NotFoundErrorController.java Outdated Show resolved Hide resolved
zaas-service/src/test/resources/zaas-messages.yml Show resolved Hide resolved
gateway-service/src/main/java/org/zowe/apiml/gateway/service/scheme/HttpBasicPassticket.java Show resolved Hide resolved
zaas-service/src/test/resources/zaas-messages.yml Show resolved Hide resolved
zaas-service/src/main/java/org/zowe/apiml/zaas/zaas/ZaasExceptionHandler.java Show resolved Hide resolved
zaas-service/src/main/java/org/zowe/apiml/zaas/zaas/ZaasExceptionHandler.java Outdated Show resolved Hide resolved
zaas-service/src/main/java/org/zowe/apiml/zaas/zaas/ZaasExceptionHandler.java Outdated Show resolved Hide resolved
zaas-service/src/test/java/org/zowe/apiml/zaas/error/ZaasErrorControllerTest.java Outdated Show resolved Hide resolved
achmelo and others added 10 commits November 1, 2024 15:55
@achmelo
code review comments
f9feac7 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
include zaas IT in jacoco
4266392 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
revert unauth handler
5c3bb34 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
zaas debug level
66af2e4 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
enabled debug logs
93494eb 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
revert spring config location
3487912 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
move profiles to jvm flags
fea3565 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
don't need specific for package
1b2368a 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
use the same method for cert PK encoding
3392030 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@pj892031
test / code coverage
9c98390 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
pj892031 and others added 5 commits November 5, 2024 13:30
@pj892031
test / code coverage - 403
8ce39c3 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pj892031
tests / code coverage
147248d 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pj892031
Merge branch 'v3.x.x' into reboot/fix-zaas-responses
9ec6eb2
@pj892031
sonar
d9fa345 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pj892031
remove unused field
f5c7881 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
pj892031 and others added 8 commits November 5, 2024 14:33
@pj892031
javax x jakarta + replace missing error with an internal error
5922b66 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pj892031
fix + test misconfigured service
037fdfe 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@achmelo
consider server cert only
506e5eb 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
Merge remote-tracking branch 'origin/reboot/fix-zaas-responses' into …
22bfbae 
…reboot/fix-zaas-responses
@achmelo
check apiml cert in header too
6297bbe 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@achmelo
return sooner, mode info in the logs
3aae107 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@pj892031
static definition for GitHub action
cb811da 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@achmelo
styles and imports
7edf24d 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
pj892031
pj892031 commented Nov 6, 2024
View reviewed changes
Copy link
Contributor Author

@pj892031 pj892031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration-tests/src/test/java/org/zowe/apiml/integration/proxy/GatewayProxyTest.java Show resolved Hide resolved
@achmelo
update number of registered services in catalog
29206be 
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pj892031 pj892031 mentioned this pull request Nov 6, 2024
Open
15 tasks
@achmelo achmelo merged commit defe1dc into v3.x.x Nov 6, 2024
27 checks passed
@achmelo achmelo deleted the reboot/fix-zaas-responses branch November 6, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocarle pablocarle pablocarle left review comments

@achmelo achmelo achmelo approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review size/XXL
Projects
API Mediation Layer Backlog Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pj892031 @pablocarle @achmelo