Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Fix for request steam failure #1022

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Conversation

KevinLoesch1
Copy link
Contributor

@KevinLoesch1 KevinLoesch1 commented Oct 18, 2023

What It Does
Corrects a bug where the HTTP request does not return when downloading larger dataset or USS file to a stream.

How to Test
Using the Zowe CLI, issue a 'zowe files copy dsclp' of a dataset that is larger than 16k. Without the fix it will fail with no error or warning message. With the fix applied it will complete as expected.

Review Checklist
I certify that I have:

  • [X ] tested my changes
  • added/updated automated tests
  • [X ] updated the changelog
  • [ X] followed the contribution guidelines

Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
packages/rest/src/client/AbstractRestClient.ts 88.92% <100.00%> (-0.27%) ⬇️

📢 Thoughts on this report? Let us know!.

CHANGELOG.md Outdated
@@ -2,6 +2,10 @@

All notable changes to the Imperative package will be documented in this file.

## Recent Changes

- BugFix: Fix for `AbstactRestClient` failing to return when streaming a larger file [#1805](https://github.com/zowe/zowe-cli/issues/1805)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 3 issues will be resolved, should we list all 3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the CHANGELOG to include all three issues.

Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@ATorrise ATorrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KevinLoesch1 KevinLoesch1 merged commit 2725328 into master Oct 19, 2023
18 of 20 checks passed
@KevinLoesch1 KevinLoesch1 deleted the fix-for-request-steam-failure branch October 19, 2023 14:38
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-patch Indicates a patch to existing code has been applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants