Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZosFilesResponse in SDK Refers to Commands #865

Closed
Tracked by #1671
dkelosky opened this issue Nov 24, 2020 · 3 comments · Fixed by #1755
Closed
Tracked by #1671

IZosFilesResponse in SDK Refers to Commands #865

dkelosky opened this issue Nov 24, 2020 · 3 comments · Fixed by #1755
Labels
community-upvoted enhancement New feature or request good first issue Good for newcomers priority-medium Not functioning - next quarter if capacity permits

Comments

@dkelosky
Copy link
Contributor

The IZosFilesResponse object that is returned from the zosfiles SDK packages contains a commandResponse:

export interface IZosFilesResponse {
    /**
     * indicates if the command ran successfully.
     * @type {boolean}
     */
    success: boolean;

    /**
     * The command response text.
     * @type{string}
     */
    commandResponse: string;

    /**
     * The api response object.
     * @type{*}
     */
    apiResponse?: any;
}

Outside the context of the Zowe CLI though, commandResponse doesn't make much sense. Can this be reworked for SDK / API users?

@JTonda JTonda added this to the 21PI1 milestone Jan 28, 2021
@zFernand0 zFernand0 removed this from the 21PI1 milestone Aug 12, 2022
@gejohnston gejohnston added enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have labels Oct 17, 2022
@github-actions
Copy link

Thank you for raising this issue.
The community has 90 days to upvote 👍 the issue.
If it receives 5 upvotes, we will move it to our backlog. If not, we will close it.

@gejohnston gejohnston added the for-review To be reviewed in an Eng & Prod Mgmt meeting label Oct 17, 2022
@t1m0thyj t1m0thyj added good first issue Good for newcomers and removed for-review To be reviewed in an Eng & Prod Mgmt meeting labels Mar 1, 2023
@gejohnston
Copy link
Member

To avoid introducing a breaking change, we do not want to change the property names, but we can change the comments to reflect that the properties could be used for other purposes than a CLI command.

@zFernand0 zFernand0 added enhancement New feature or request and removed enhancement New feature or request labels Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@zFernand0 zFernand0 added community-upvoted priority-medium Not functioning - next quarter if capacity permits and removed priority-low Legit issue but cosmetic or nice-to-have labels Mar 8, 2023
@zFernand0 zFernand0 mentioned this issue Mar 29, 2023
28 tasks
@adam-wolfe adam-wolfe mentioned this issue May 31, 2023
19 tasks
@ATorrise ATorrise linked a pull request Jul 20, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-upvoted enhancement New feature or request good first issue Good for newcomers priority-medium Not functioning - next quarter if capacity permits
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants