Fix error when listing ds members that include '"' #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
requested review from
gejohnston,
zFernand0,
awharn,
traeok,
KevinLoesch1 and
ATorrise
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1753 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 422 422
Lines 7165 7165
Branches 1309 1309
=======================================
Hits 6649 6649
Misses 515 515
Partials 1 1
☔ View full report in Codecov by Sentry. |
traeok
approved these changes
Jul 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
ATorrise
reviewed
Jul 20, 2023
| @@ -135,7 +135,7 @@ export class EditUtilities { | |||
| input = await CliUtils.readPrompt(TextUtils.chalk.green(promptText)); | |||
| } | |||
| while (input != null && input.toLowerCase() != 'y' && input.toLowerCase() != 'n'); | |||
| if (input === null) { | |||
| if (input == null) { | |||
ATorrise
approved these changes
Jul 20, 2023
KevinLoesch1
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Fixes a bug in the implementation of #1730 - error when listing data set members that include double quote in the name.
How to Test
There isn't really a way to test the changes manually. The error is only reproducible in the unit test "should list members from given data set that contains a member with an invalid name" which generates random member names to test with. The member name that was previously failing the test is
XK"¶J9 ^, and I've verified that it now passes with this member name.Review Checklist
I certify that I have:
Additional Comments