Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secrets SDK package to include the right files #1769

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

t1m0thyj
Copy link
Member

What It Does
The publish workflow succeeded for the Secrets SDK, but resulted in an 80MB TGZ containing the wrong files:
https://zowe.jfrog.io/ui/repos/tree/General/npm-local-release/@zowe/secrets-for-zowe-sdk/-/@zowe/secrets-for-zowe-sdk-7.18.0-next.1.tgz

  • Restore .npmignore from @traeok's repo to exclude Rust binaries in target dir
  • Move JS source into lib folder and include it in the package
  • Include Cargo.lock for keyring package in this repo
  • Consolidate multiple .gitignore files into one

How to Test
Check out this branch
Run npm install and npm run build
Then cd into packages/secrets and run npm pack
Verify that the list of files added to the TGZ looks good

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (08be45b) 92.79% compared to head (b97a410) 92.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1769      +/-   ##
==========================================
- Coverage   92.79%   92.78%   -0.02%     
==========================================
  Files         422      423       +1     
  Lines        7165     7166       +1     
  Branches     1309     1309              
==========================================
  Hits         6649     6649              
- Misses        515      516       +1     
  Partials        1        1              
Files Changed Coverage Δ
packages/secrets/src/index.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj marked this pull request as ready for review July 31, 2023 14:29
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@t1m0thyj t1m0thyj merged commit 62fc64f into master Jul 31, 2023
23 of 25 checks passed
@t1m0thyj t1m0thyj deleted the fix/secrets-sdk-package branch July 31, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants