Fix secrets SDK package to include the right files #1769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
The publish workflow succeeded for the Secrets SDK, but resulted in an 80MB TGZ containing the wrong files:
https://zowe.jfrog.io/ui/repos/tree/General/npm-local-release/@zowe/secrets-for-zowe-sdk/-/@zowe/secrets-for-zowe-sdk-7.18.0-next.1.tgz
.npmignore
from @traeok's repo to exclude Rust binaries intarget
dirlib
folder and include it in the packageCargo.lock
for keyring package in this repo.gitignore
files into oneHow to Test
Check out this branch
Run
npm install
andnpm run build
Then cd into
packages/secrets
and runnpm pack
Verify that the list of files added to the TGZ looks good
Review Checklist
I certify that I have:
Additional Comments