Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating help text for zosfiles view #1773

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Updating help text for zosfiles view #1773

merged 2 commits into from
Aug 3, 2023

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Aug 2, 2023

What It Does
Fixes #1751 using IBM documentation for reference

Review Checklist
I certify that I have:

Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
@ATorrise ATorrise self-assigned this Aug 2, 2023
@ATorrise ATorrise marked this pull request as ready for review August 2, 2023 18:38
Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise!

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, hope they're helpful!

Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (99809f0) 92.78% compared to head (6771624) 92.78%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1773   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         423      423           
  Lines        7165     7165           
  Branches     1308     1308           
=======================================
  Hits         6648     6648           
  Misses        516      516           
  Partials        1        1           
Files Changed Coverage Δ
packages/cli/src/zosfiles/-strings-/en.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zFernand0 zFernand0 merged commit ad53774 into master Aug 3, 2023
20 checks passed
@zFernand0 zFernand0 deleted the helpText branch August 3, 2023 17:39
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with --range help text
7 participants