-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating help text for zosfiles view
#1773
Conversation
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions, hope they're helpful!
...__/zosfiles/__integration__/view/ds/__snapshots__/cli.files.view.ds.integration.test.ts.snap
Outdated
Show resolved
Hide resolved
...__/zosfiles/__integration__/view/ds/__snapshots__/cli.files.view.ds.integration.test.ts.snap
Outdated
Show resolved
Hide resolved
.../zosfiles/__integration__/view/uss/__snapshots__/cli.files.view.uss.integration.test.ts.snap
Outdated
Show resolved
Hide resolved
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1773 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 423 423
Lines 7165 7165
Branches 1308 1308
=======================================
Hits 6648 6648
Misses 516 516
Partials 1 1
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What It Does
Fixes #1751 using IBM documentation for reference
Review Checklist
I certify that I have: