-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only showing command output in stdout for zowe uss issue cmd
#1776
Conversation
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1776 +/- ##
==========================================
+ Coverage 92.82% 92.88% +0.05%
==========================================
Files 423 423
Lines 7191 7193 +2
Branches 1319 1320 +1
==========================================
+ Hits 6675 6681 +6
+ Misses 515 511 -4
Partials 1 1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments,
Not sure what to do about the $
since I can't seem to find how to change it on my USS session.
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I build and install this branch I am not seeing any output from issuing ssh commands.
With this branch:
PS C:\Users\me\GitRepos\zowe-cli\packages\cli> npm install -g
removed 278 packages, changed 1 package, and audited 3 packages in 5s
found 0 vulnerabilities
PS C:\Users\me\GitRepos\zowe-cli\packages\cli> zowe ssh issue cmd "echo hello;echo hello"
PS C:\Users\me\GitRepos\zowe-cli\packages\cli> zowe ssh issue cmd "echo hello;echo hello" --rfj
{
"success": true,
"exitCode": 0,
"message": "",
"stdout": "\n",
"stderr": "",
"data": {}
}
With latest from npmjs:
PS C:\Users\me\GitRepos\zowe-cli\packages\cli> npm install -g @zowe/cli
added 278 packages, changed 1 package, and audited 280 packages in 23s
13 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
PS C:\Users\me\GitRepos\zowe-cli\packages\cli> zowe ssh issue cmd "echo hello;echo hello"
$ hello
hello
PS C:\Users\me\GitRepos\zowe-cli\packages\cli> zowe ssh issue cmd "echo hello;echo hello" --rfj
{
"success": true,
"exitCode": 0,
"message": "",
"stdout": "\r\n$ hello\r\nhello\n",
"stderr": "",
"data": {}
}
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…age.json Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
Kudos, SonarCloud Quality Gate passed! |
What It Does
Fixes Issue #1724
How to Test
Run any command with
zowe uss issue cmd "chosenCommand" --rfj
and verify that$chosenCommand
isn't present in the stdout of the json response.Review Checklist
I certify that I have:
Additional Comments
Newline padding removal has been left out of this fix. This is because line endings appear to vary across systems and commands and rather than attempt to remove these endings and cause some unintended break, it seems easier to have the end user remove this information if they choose.