pkg(secrets): Add bundler instructions to EXTENDERS.md; fix README link; resolve pkg root for prebuilds
#1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1783 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 423 423
Lines 7191 7191
Branches 1319 1319
=======================================
Hits 6675 6675
Misses 515 515
Partials 1 1 ☔ View full report in Codecov by Sentry. |
traeok
changed the title
prebuildsEXTENDERS.md; fix README link; resolve pkg root for prebuilds
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
requested review from
t1m0thyj,
zFernand0,
awharn,
KevinLoesch1 and
ATorrise
t1m0thyj
reviewed
Aug 14, 2023
t1m0thyj
reviewed
Aug 14, 2023
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
98c1493
to
b94a9ed
Compare
…age.json Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
a4e31b5
to
b858ee0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
4be4b5d
to
6c5edd6
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
6c5edd6
to
652d705
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
495abe5
to
75e812a
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
be633c5
to
8ba3790
Compare
t1m0thyj
reviewed
Aug 14, 2023
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
23e6621
to
0defd96
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
doc/secrets/webpack-and-import
branch
from
0defd96
to
a350487
Compare
t1m0thyj
approved these changes
Aug 14, 2023
awharn
approved these changes
Aug 14, 2023
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
|
Kudos, SonarCloud Quality Gate passed!
|
traeok
added
the
release-current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This PR adds the following:
prebuilds/folderREADME.mdworked locally and in GitHub, but not from NPM's websiteEXTENDERS.mdto include steps on how to bundle the Secrets SDK alongside a webpacked extension/packageHow to Test
To test the enhancement, run the
prepublishOnlyscript after building the Secrets SDK, and then run the test stage:npm installnpm run prepublishOnly && npm run build && npm run testThe Secrets SDK will use the
prebuildsfolder in its package root to resolve & load the Node-native binary.Review Checklist
I certify that I have:
Additional Comments