--help fail on config json error #2301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2301 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 636 636
Lines 18029 18042 +13
Branches 3767 3776 +9
=======================================
+ Hits 16434 16447 +13
Misses 1594 1594
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
t1m0thyj
reviewed
Oct 11, 2024
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
ATorrise
changed the title
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
zFernand0
reviewed
Oct 28, 2024
t1m0thyj
previously requested changes
Oct 29, 2024
packages/imperative/src/cmd/__tests__/CommandProcessor.unit.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
Signed-off-by: Amber Torrise <amber.torrise@broadcom.com>
ATorrise
force-pushed
the
error-msg-help-version
branch
from
7eb5d56
to
d7ea329
Compare
|
was testing a revert to see if error in test persisted adding a note so that theres less confusion when reviewing... i went back in my commit history locally by doing a git reset –soft [commit hash] to check if my failing tests were still failing. rather than deleting this local branch and re downloading from remote, i instead pushed all those changes back up, making several commits and merges look like 1 commit in an attempt to restore the progress made. |
Signed-off-by: Amber <amber.torrise@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
…hat was missed in imperative cleanup Signed-off-by: Amber <amber.torrise@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Amber <amber.torrise@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
…msg-help-version Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
zFernand0
force-pushed
the
error-msg-help-version
branch
from
bfde641
to
6545a33
Compare
Signed-off-by: Amber <amber.torrise@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Amber <amber.torrise@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
|
Added the
|
Signed-off-by: Amber <amber.torrise@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
zFernand0
approved these changes
Nov 5, 2024
Signed-off-by: Amber <amber.torrise@broadcom.com>
…-cli into error-msg-help-version
zFernand0
dismissed
t1m0thyj’s stale review
I believe these changes were addressed 😋
t1m0thyj
requested changes
Nov 5, 2024
packages/cli/__tests__/zosfiles/__unit__/upload/ftds/FileToDataSet.handler.unit.test.ts
Show resolved
Hide resolved
packages/imperative/src/imperative/src/config/cmd/report-env/EnvItems.ts
Show resolved
Hide resolved
ATorrise
commented
Nov 6, 2024
Signed-off-by: Amber <amber.torrise@broadcom.com>
t1m0thyj
previously requested changes
Nov 6, 2024
packages/imperative/src/config/__tests__/Config.api.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/imperative/src/config/__tests__/Config.api.unit.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Amber <amber.torrise@broadcom.com>
anaxceron
approved these changes
Nov 6, 2024
Signed-off-by: Amber <amber.torrise@broadcom.com>
zFernand0
approved these changes
Nov 6, 2024
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Ensures users can still access the help documentation and version details, even when config files contain errors.
How to Test
zowe.config.jsonfile with invalid JSON or syntax errors.--helpflag, ie:zowe zosmf --help--helpflag to ensure it still fails as expected with a JSON error.Review Checklist
I certify that I have: