Enhancing GetJobs.getJob

[pujal0909]

What It Does
Adds "exec-started" and "exec-ended" to IJob return data from GetJobs.getJob

How to Test
Download branch and test a command that uses GetJobs.getJob in the background - set a breakpoint and ensure that the job being returned has the expected timestamps.

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments
Other exec properties were included in the zosmf response from GetJobs. Should we include these other properties starred in the image? @t1m0thyj @zFernand0 @gejohnston @awharn

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (2a2ba4b) to head (5d7f071).
Report is 18 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2320    +/-   ##
========================================
  Coverage   91.10%   91.10%            
========================================
  Files         628      628            
  Lines       17891    17891            
  Branches     3844     3737   -107     
========================================
  Hits        16300    16300            
  Misses       1590     1590            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zFernand0]

I like your observation! 🙏
We should probably add the rest of the exec-data parameters to the iJob interface.

Ideally we would figure out a way to prevent changes in so many places 😢

[zFernand0]

FWIW, this PR LGTM 😋

Should we add a changelog entry to the CLI package since this will also affect the default behavior of the CLI? 😅

Here is a quick before and after 🥳

Before

zFernand0 : ~/gh/zowe/cli > zowe jobs list jobs --prefix "izu*" --owner "*" --rfj | jq '.data[0]'
{
  "owner": "IZUSVR",
  "phase": 20,
  "subsystem": "JES2",
  "phase-name": "Job is on the hard copy queue",
  "job-correlator": "S0003689USI220MEDFD7F395.......:",
  "type": "STC",
  "url": "https://lpar.dev:1234/zosmf/restjobs/jobs/S0003689USI220MEDFD7F395.......%3A",
  "jobid": "STC03689",
  "class": "STC",
  "files-url": "https://lpar.dev:1234/zosmf/restjobs/jobs/S0003689USI220MEDFD7F395.......%3A/files",
  "jobname": "IZUSVR1",
  "status": "OUTPUT",
  "retcode": "SYS FAIL"
}

After

zFernand0 : ~/gh/zowe/cli > zdev jobs list jobs --prefix "izu*" --owner "*" --rfj | jq '.data[0]'
{
  "owner": "IZUSVR",
  "phase": 20,
  "exec-member": "SYS1",
  "subsystem": "JES2",
  "phase-name": "Job is on the hard copy queue",
  "job-correlator": "S0003689USI220MEDFD7F395.......:",
  "type": "STC",
  "url": "https://lpar.dev:1234/zosmf/restjobs/jobs/S0003689USI220MEDFD7F395.......%3A",
  "jobid": "STC03689",
  "exec-system": "SYS1",
  "exec-submitted": "2024-10-14T08:25:30.470Z",
  "class": "STC",
  "files-url": "https://lpar.dev:1234/zosmf/restjobs/jobs/S0003689USI220MEDFD7F395.......%3A/files",
  "jobname": "IZUSVR1",
  "status": "OUTPUT",
  "retcode": "SYS FAIL",
  "exec-started": "2024-10-14T08:25:32.010Z"
}

[traeok]

LGTM! Thanks Pujal for the fix 🙂

[gejohnston]

Your changes satisfy my earlier comments. However, Adam's comment seems like something that should be investigated and resolved before you merge your pull request. Once you address Adam's question, I am ready to approve.

[pujal0909]

Quality Gate failed

Failed conditions 25.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Can we ignore this SonarCloud Quality gate caught error? This file already contained heavily duplicated test data that supports test cases. @t1m0thyj @zFernand0 @awharn @gejohnston

[zFernand0]

Quality Gate failed

Failed conditions 25.0% Duplication on New Code (required ≤ 3%)
See analysis details on SonarCloud

Can we ignore this SonarCloud Quality gate caught error? This file already contained heavily duplicated test data that supports test cases. @t1m0thyj @zFernand0 @awharn @gejohnston

I don't disagree with tackling this in a future issue.
The zos-jobs tests can definitely use some refactoring to reduce overall code duplication 😋

[zFernand0]

LGTM! 😋
Thanks for addressing all PR feedback 🥳
Merging as soon as checks are done! 🥳

[sonarcloud]

Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

These requested changes have been address 🙏

[github-actions]

Release succeeded for the master branch. 🎉

The following packages have been published:

• npm: @zowe/zos-jobs-for-zowe-sdk@8.5.0
• npm: @zowe/cli@8.5.0

_{Powered by Octorelease 🚀}