fix: Ignore events within the app that triggered them #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/convert-v1-profiles #2323 +/- ##
===========================================================
+ Coverage 91.14% 91.24% +0.09%
===========================================================
Files 636 636
Lines 18033 18038 +5
Branches 3876 3878 +2
===========================================================
+ Hits 16437 16458 +21
+ Misses 1595 1579 -16
Partials 1 1 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Oct 28, 2024
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
force-pushed
the
fix/event-emitter-ignore-same-proc
branch
from
6672b4b
to
ca1a715
Compare
|
t1m0thyj
requested review from
anaxceron,
zFernand0,
gejohnston,
awharn,
traeok,
jace-roell and
ATorrise
Draft
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Resolves #2279 and fixes #2324
Although the first issue was originally filed as an enhancement, I listed it in the changelog as a bug fix.
This PR is related to #2313 since it contains fixes targeted for ZE, but I opened it separately for easier review.
How to Test
I can demo these changes in ZE on a standup.
Review Checklist
I certify that I have:
Additional Comments