Zos download attributes #2335
Open
Zos download attributes #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2335 +/- ##
==========================================
+ Coverage 91.15% 91.16% +0.01%
==========================================
Files 636 636
Lines 18029 18034 +5
Branches 3767 3877 +110
==========================================
+ Hits 16434 16441 +7
+ Misses 1594 1592 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
packages/zosfiles/__tests__/__system__/methods/download/Download.system.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: jace-roell <jace.roell@hotmail.com>
packages/zosfiles/__tests__/__system__/methods/download/Download.system.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
t1m0thyj
reviewed
Nov 5, 2024
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
awharn
previously requested changes
Nov 6, 2024
packages/zosfiles/__tests__/__system__/methods/download/__resources__/download_file.sh
Outdated
Show resolved
Hide resolved
packages/zosfiles/__tests__/__system__/methods/download/__resources__/upload_file_to_uss.sh
Outdated
Show resolved
Hide resolved
...es/zosfiles/__tests__/__system__/methods/download/__resources__/upload_file_to_uss_binary.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
anaxceron
reviewed
Nov 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Added optional
--attributesflag tozowe zos-files download uss-fileto allow passing a .zosattributes file path for download encoding format.Review Checklist
I certify that I have: